Quadra script bugfix: rotational shift between STIR and Siemens recons#1688
Quadra script bugfix: rotational shift between STIR and Siemens recons#1688KrisThielemans merged 5 commits intoUCL:masterfrom
Conversation
KrisThielemans
left a comment
KrisThielemans
left a comment
There was a problem hiding this comment.
Can you please change the view_offset in Scanner.cxx, for both Vison 600 and Quadra? We then wouldn't need this change in the preprocess scripts anymore.
In any case, it avoids wrong things when NOT using the preprocess scripts.
|
I've merged #1681, which might give you a conflict for the python exponent (but I don't think so) |
…nd remove view_offset in pre_processing scripts
Have implemented the view offset in the Scanner.cxx for both Vision and Quadra. |
KrisThielemans
left a comment
KrisThielemans
left a comment
There was a problem hiding this comment.
Unfortunately, some white space and other unnecessary changes. The former should disappear when you run pre-commit run --all.
Main question is: did you run it and see if it gave the same header? (for Vision 600 and Quadra I guess)
| DOI = proj_info.get_scanner().get_average_depth_of_interaction() | ||
| print('New Depth of interaction:', DOI) | ||
|
|
||
| def view_offset_adaption(projdata, view_offset): |
There was a problem hiding this comment.
I guess I'd leave the function in, in case we need it in the future (but not use it)
There was a problem hiding this comment.
sure, I will leave this in
3 participants
Changes in this pull request
Included a view offset in the projection data to make sure no rotational shifts occur between Siemens and STIR reconstructions for Quadra data. As done in PR #1682.
Some small modifications were also implemented.
Testing performed
Related issues
Checklist before requesting a review
documentation/release_XXX.mdhas been updated with any functionality change (if applicable)Contribution Notes
Please tick the following: