Skip to content

Cervical cancer #1287

Merged
tbhallett merged 381 commits intomasterfrom
cervical_cancer_
Jul 22, 2025
Merged

Cervical cancer #1287
tbhallett merged 381 commits intomasterfrom
cervical_cancer_

Conversation

@andrew-phillips-1
Copy link
Copy Markdown
Collaborator

Here's a first draft of this module. I need to do another search to try to find additional data for calibration.

I couldn't upload the draft write as it was asking me to use the command line and Git LFS.

@mnjowe
Copy link
Copy Markdown
Collaborator

mnjowe commented Apr 2, 2024

Thanks @andrew-phillips-1 for this first draft. I think it looks good. I will be adding some few comments/suggestions for your consideration.

@andrew-phillips-1
Copy link
Copy Markdown
Collaborator Author

Thanks @mnjowe

@tbhallett
Copy link
Copy Markdown
Collaborator

This will be ready once we have updated version of write-up.

@tbhallett
Copy link
Copy Markdown
Collaborator

@mnjowe --- I think this is ready to go now and all your comments have been addressed. Please could you approve the PR, and we'll get it merged?

@tbhallett tbhallett removed the request for review from tdm32 June 30, 2025 10:38
@tamuri
Copy link
Copy Markdown
Collaborator

tamuri commented Jul 9, 2025

test_all_treatment_ids_defined_in_priority_policies in test_healthsystem failed on following line:

assert set(policy) == clean_set_of_filtered_treatment_ids  # Check that all treatment_ids defined are allowed

# Conflicts:
#	resources/ResourceFile_Improved_Healthsystem_And_Healthcare_Seeking/main.csv
#	resources/healthsystem/priority_policies/ResourceFile_PriorityRanking_ALLPOLICIES/CVD.csv
#	resources/healthsystem/priority_policies/ResourceFile_PriorityRanking_ALLPOLICIES/ClinicallyVulnerable.csv
#	resources/healthsystem/priority_policies/ResourceFile_PriorityRanking_ALLPOLICIES/Default.csv
#	resources/healthsystem/priority_policies/ResourceFile_PriorityRanking_ALLPOLICIES/EHP_III.csv
#	resources/healthsystem/priority_policies/ResourceFile_PriorityRanking_ALLPOLICIES/LCOA_EHP.csv
#	resources/healthsystem/priority_policies/ResourceFile_PriorityRanking_ALLPOLICIES/Naive.csv
#	resources/healthsystem/priority_policies/ResourceFile_PriorityRanking_ALLPOLICIES/RMNCH.csv
#	resources/healthsystem/priority_policies/ResourceFile_PriorityRanking_ALLPOLICIES/Test Mode 1.csv
#	resources/healthsystem/priority_policies/ResourceFile_PriorityRanking_ALLPOLICIES/Test.csv
#	resources/healthsystem/priority_policies/ResourceFile_PriorityRanking_ALLPOLICIES/VerticalProgrammes.csv
@tbhallett
Copy link
Copy Markdown
Collaborator

test_all_treatment_ids_defined_in_priority_policies in test_healthsystem failed on following line:

assert set(policy) == clean_set_of_filtered_treatment_ids  # Check that all treatment_ids defined are allowed

now fixed!

@tbhallett tbhallett requested review from mnjowe and thewati and removed request for thewati July 21, 2025 13:09
@tbhallett
Copy link
Copy Markdown
Collaborator

I think this is ready now, including all of the requested changes by @mnjowe

@mnjowe --- if you're happy please could you approve this updated version?

Copy link
Copy Markdown
Collaborator

@mnjowe mnjowe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Andrew and all for the amazing work on cervical cancer and for addressing all my comments. This is looking great!

@andrew-phillips-1
Copy link
Copy Markdown
Collaborator Author

Thanks Emmanuel. It was Tim who got us over the line.

@tbhallett tbhallett merged commit 91e89b4 into master Jul 22, 2025
63 checks passed
@tbhallett tbhallett deleted the cervical_cancer_ branch July 22, 2025 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants