Remove reference to squeeze factors in test and mode 1 check#1689
Closed
marghe-molaro wants to merge 3 commits intomasterfrom
Closed
Remove reference to squeeze factors in test and mode 1 check#1689marghe-molaro wants to merge 3 commits intomasterfrom
marghe-molaro wants to merge 3 commits intomasterfrom
Conversation
…sed_on_squeeze_factors and when checking if mode 1 appointments can go ahead
Collaborator
Author
|
@tamuri test_epi.py was cancelled but is running fine locally. Everything else is passing. |
This was referenced Jan 14, 2026
Collaborator
|
Closing in favour of #1781 |
marghe-molaro
added a commit
that referenced
this pull request
Jan 29, 2026
* Remove squeeze factor from HS * Ensure default logging for multiple treatment ids * Replaced rescaling of capabilities based on squeeze so that it is based on load * Ensure running footprint and load is clinic specific * Add clinics running footprint and test * For test to pass for now only log Capacity_By_FacID_and_Officer for GenericClinic * Style fixes * Fix test of squeeze logging * More logging fixes in test * Update comment in test because rescaling factor cannot be less than 1 * Consistent variable names * Remove redundant function log_current_capabilities_and_usage called log_clinic_current_capabilities_and_usage looping over the clinics. I have now removed log_clinic_current_capabilities_and_usage, and moved the looping logic to where the capabilities are logged. * Retrieve facility id and district from appointment type needs * Additional comments in tests to explain rationale I have updated comments in the test to explain the rationale for retaining an arbitrary clinic capabilities split in test set up. * WIP: looping over clinics to log * Debugging * All but one tests pass * WIP; debugging * Fix test rescaling capabilities based on load factors * Style fixes * Style fixes Signed-off-by: sangeetabhatia03 <sangeetabhatia03@gmail.com> * Remove print statements --------- Signed-off-by: sangeetabhatia03 <sangeetabhatia03@gmail.com> Co-authored-by: sangeetabhatia03 <sangeetabhatia03@gmail.com> Co-authored-by: Tim Hallett <39991060+tbhallett@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is related to PR #1662 and addresses the following issues:
test_run_in_mode_1_with_almost_no_capacityhas now been removed fromtest_healthsystem.py, as it is outdatedThe reference to squeeze has been removed from
test_rescaling_capabilities_based_on_squeeze_factors, which has been renamed totest_rescaling_capabilities_based_on_load_factors.The reference to squeeze has also been removed from the check determining whether HSI in mode 1 can proceed. The check now verifies if any required officer has a non-zero capability, rather than checking if any squeeze factor is inf.