Remove _check_if_appt_footprint_can_run#1751
Merged
Conversation
Collaborator
|
This check was more used in development to see if such an HSI could ever run. This was done to prevent HSI with mad configurations of officer needs (e.g. a surgeon at level 0) clogging the queue. I agree we can remove it though... |
tbhallett
approved these changes
Nov 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
_check_if_appt_footprint_can_run is outdated and can be removed. Checks on whether HSI can run or not should be carried out only at the time when the HSI is ran, not initialised, as capabilities/mode of appt delivery may change with time. This will also assist in clinics design (PR #1617).