Conversation
Collaborator
|
Looks like mode2 test took only 4 mins! |
Collaborator
Author
|
Ok, will try something else! |
Collaborator
|
The big ones are these three: |
test_healthsystem.py into two files to enable parallel running and so speed us testing.test_healthsystem.py into two files to enable parallel running and so speed up testing.
Collaborator
Author
|
Now completing in So, could split |
tamuri
approved these changes
Feb 26, 2026
Collaborator
tamuri
left a comment
There was a problem hiding this comment.
Thanks, Tim. This cuts the current test runtime in about half - merging!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here I propose a split of the
test_healthsystem.pyinto:test_healthsystem_general_and_mode1.py: This test file is focussed on the overall function of the module and its behaviour in Mode 1.test_healthsystem_mode2.py: This test file is focussed on behaviour in Mode 2 (including rescaling and clinics).This feels like a logical way to split the tests. However, the first of these still contains more tests, so may still take much longer. If necessary, a further cut could be made!