Remove unused conda data-fetcher function and therefore remove DuckDB dependency.#106
Merged
samcunliffe merged 8 commits intomainfrom Feb 1, 2026
Merged
Conversation
64c7915 to
5f1bacb
Compare
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
...and the dependency!?
…c-to-duckdb-node-api
giordano
approved these changes
Feb 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DuckDB depends on a very old and vulnerable version of tar. DuckDB devs have deprecated the thing we were using (so not updating either it or its dependencies)...
But it turns out we're not actually using the conda-data-fetcher function. So rather than update DuckDB's node API (the branch name of this PR) we can just remove it completely... 🎉 Less code is less code.
I didn't notice this ages ago, because I'm not a very good JavaScript developer.