Token via Osscar the OSS cat (our very own GitHub app).#38
Merged
samcunliffe merged 5 commits intomainfrom Oct 15, 2025
Merged
Conversation
Co-authored-by: Mosè Giordano <giordano@users.noreply.github.com>
Closed
samcunliffe
changed the title
giordano
reviewed
Oct 15, 2025
Comment on lines
-40
to
-45
| - name: Restore conda downloads cache | ||
| uses: actions/cache@v4 | ||
| with: | ||
| path: | | ||
| ~/.dashboard | ||
| key: conda-download-cache-${{ env.DATE }} |
Member
There was a problem hiding this comment.
For the benefit of future readers, we discussed this offline: this chunk was missed in #27, it's technically orthogonal to this PR.
Member
Author
|
Yäy! 🥳 |
There was a problem hiding this comment.
Pull Request Overview
This PR replaces personal access token authentication with a GitHub App token for improved rate limits and security. The GitHub App token expires after one hour, providing better security than long-lived personal tokens.
- Removes global environment variables and integrates GitHub App token generation
- Adds token generation step using the
actions/create-github-app-tokenaction - Moves environment variables to the specific step that needs them
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
samcunliffe
added
enhancement
samcunliffe
commented
Oct 15, 2025
Merged
samcunliffe
added a commit
that referenced
this pull request
Oct 31, 2025
* Workflow update. Co-authored-by: Mosè Giordano <giordano@users.noreply.github.com> * Remove GRAPHQL_TOKEN from the `env` 🤦 * (Temporarily) delete concurency group * Revert temporary disabling of the concurrency rules. Also add a timeout. --------- Co-authored-by: Mosè Giordano <giordano@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Better rate limit than a personal token. (🎉)
Potentially more secure, as the GRAPHQL_TOKEN expires after one hour (we do have to upload the private key of the app as a repo secret though, so ¯\_(ツ)_/¯ )