Skip to content

fix: APPS-3685 Add External Link to BlockCardWithImage#886

Draft
jendiamond wants to merge 8 commits intomainfrom
APPS-3592_collections_hearst-metrotone-fixes
Draft

fix: APPS-3685 Add External Link to BlockCardWithImage#886
jendiamond wants to merge 8 commits intomainfrom
APPS-3592_collections_hearst-metrotone-fixes

Conversation

@jendiamond
Copy link
Copy Markdown
Member

@jendiamond jendiamond commented Jan 15, 2026

Connected to APPS-3685

https://deploy-preview-886--ucla-library-storybook.netlify.app/?path=/story/block-card-with-image--ftva-custom-description-only-external-link

Changes

  1. Add capability for the CardWithImage to have ONLY a Description and still be linkable
  2. Add capability for the CardWithImage to have External link capability
  3. Update the name of the story FTVACustomTitleDescription to FTVACustomTitleAndDescription
  4. Add a story FTVA Custom Description Only External Link

Notes:

Previously the component could only take internal links.

Once this component is updated I have to update the collections/index.vue page

  1. Update
      <block-card-with-image
        class="block-highlight"
        style="cursor: pointer"
        :image="image"
        :image-aspect-ratio="imageAspectRatio"
        :cardIsLink="true"
        :to="uri"
        >
        <template #customDescription>
          <rich-text v-html="ftvaHomepageDescription" />
        </template>
      </block-card-with-image>
    
  2. Add css style .is-link { cursor: pointer }
Screenshot 2026-01-15 at 12 41 12 PM

Checklist:

  • I checked that it is working locally in the storybook
  • I added a screenshot of it working
  • UX has reviewed and approved this
  • I assigned this PR to someone on the dev team to review
  • I used a conventional commit message
  • I assigned myself to this PR

@jendiamond jendiamond self-assigned this Jan 15, 2026
@jendiamond jendiamond added the fix label Jan 15, 2026
@github-actions
Copy link
Copy Markdown
Contributor

Percy Screenshots

In order to conserve our percy screenshot allowance, percy is not configured to run automatically. Please make sure the PR is ready and all other checks are passing, then start it manually:

  1. Visit https://github.com/UCLALibrary/ucla-library-website-components/actions/workflows/percy.yml 2. Click the 'Run workflow' button in the blue bar. 3. Select the correct branch for this PR and click 'Run workflow' again to confirm.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jan 15, 2026

@github-actions github-actions bot temporarily deployed to storybook--pull_request-886 January 15, 2026 20:39 Inactive
@github-actions github-actions bot temporarily deployed to storybook--pull_request-886 January 15, 2026 21:28 Inactive
@pghorpade pghorpade marked this pull request as draft January 16, 2026 21:07
@jendiamond jendiamond changed the title fix: APPS-3592 Hearst Metrotone News Collection card on Explore Collections template does not have a link associated with it fix: APPS-3685 Add External Link to BlockCardWithImage Jan 19, 2026
@github-actions github-actions bot temporarily deployed to storybook--pull_request-886 January 19, 2026 07:25 Inactive
@jendiamond jendiamond force-pushed the APPS-3592_collections_hearst-metrotone-fixes branch from c18872b to 42e28dc Compare January 19, 2026 07:28
@github-actions github-actions bot temporarily deployed to storybook--pull_request-886 January 19, 2026 07:31 Inactive
@jendiamond
Copy link
Copy Markdown
Member Author

Parinita Mulak  [2:59 PM]
@jendiamond this ticket https://uclalibrary.atlassian.net/browse/APPS-3592 is in release column on our board , but i see a draft PR still, do you know what is going on with this ticket? and if its working on test-ftva site?
Jira CloudOpen1 replyjendiamond  [7:22 PM]
The Hearst card link was merged a while back:
Here it is working
https://cinema.ucla.edu/collections
UCLALibrary/ftva-website-nuxt#298
The branch name changed for that work to:
APPS-3592_collections_hearst-metrotone-fixes
and it apparently didn't update in the Jira.

The branch APPS-3592_collections_hearst-metrotone-fixes
#886
is for the work of adding the  External Link to BlockCardWithImage in the component
https://uclalibrary.atlassian.net/browse/APPS-3685
which is ticket
#886

I discovered that this functionality was missing while doing this work and thought that it was part of that ticket but we decided to break it apart. I started a new branch because I had already done the work to make it an external link in this Draft PR. 

@github-actions github-actions bot temporarily deployed to storybook--pull_request-886 February 18, 2026 03:31 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants