Open
Conversation
- marks footer as already existing
Contributor
|
@lux-v The vertical divider in the metadata doesn’t line up with the edge of the hero image, which makes the layout feel a bit disconnected—especially when the metadata is sparse. Could we align both sections to the same column grid so the divider matches the image boundary? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These pages are built for Storybook and serve as mocked examples to demonstrate page composition and data flow using existing components.
All pages use mock data from
stories/mock/Funkhaus, whilePageMainSearchFieldResults.storiesincludes an example Elasticsearch integration using the useElasticsearchSearch composable.useElasticsearchSearchis a lightweight, MVP-level composable used only for demonstration purposes. It showcases how search queries, filters, pagination, and sorting can be translated into Elasticsearch requests and consumed at the page level. Due to the Storybook environment and URL-based search handling, this implementation should be treated as an example of usage.Overall, this PR provides reference implementations to guide future page integration.
Design link:
https://www.figma.com/design/CDhWDARLb36ftkQce1LyLC/Breakpoints?node-id=51-781&m=dev