fix: LADI-3746 Revisit logic for rendering button in Block media with text component#927
Open
jendiamond wants to merge 10 commits intomainfrom
Conversation
Contributor
Chromatic ScreenshotsIn order to conserve our chromatic screenshot allowance, chromatic is not configured to run automatically. Please make sure the PR is ready and all other checks are passing, then start it manually:
|
Contributor
Percy ScreenshotsIn order to conserve our percy screenshot allowance, percy is not configured to run automatically. Please make sure the PR is ready and all other checks are passing, then start it manually:
|
Contributor
github-actions
bot
temporarily deployed
to
storybook--pull_request-927
github-actions
bot
temporarily deployed
to
storybook--pull_request-927
jendiamond
force-pushed
the
LADI-3746_revisit-logic-for-rendering-button-in-Block-media-with-text-component
branch
from
57872c8 to
8005dfc
Compare
…-in-Block-media-with-text-component
github-actions
bot
temporarily deployed
to
storybook--pull_request-927
…-in-Block-media-with-text-component
github-actions
bot
temporarily deployed
to
storybook--pull_request-927
…-in-Block-media-with-text-component
…-in-Block-media-with-text-component
…-in-Block-media-with-text-component
pghorpade
requested changes
Apr 1, 2026
packages/vue-component-library/src/lib-components/BlockMediaWithText.vue
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Connected to APPS-3746
This makes sure that no empty buttons appear on the page.
The component now checks for both button text and URL before rendering, improving accessibility.