Skip to content

Issue82#93

Merged
lgatto merged 5 commits intomasterfrom
issue82
May 30, 2025
Merged

Issue82#93
lgatto merged 5 commits intomasterfrom
issue82

Conversation

@cvanderaa
Copy link
Member

See #82 for background.

Here is an example after the new implementation where samples and carrier could be found in a set, but not in the other 2:

data(scp1)
scp1$SampleType[1:3] <- "foo" ## "foo" samples are only found in the first set
computeSCR(
    scp1, i = 1:3, colvar = "SampleType",
    samplePattern = "foo", carrierPattern = "foo"
)

(Expected) error:

Error in computeSCR(scp1, i = 1:3, colvar = "SampleType", samplePattern = "foo",  : 
  No match found with 'samplePattern = "foo"' for the following set(s):
190321S_LCA10_X_FP97AG, 190914S_LCB3_X_16plex_Set_21
No match found with 'carrierPattern = "foo"' for the following set(s):
190321S_LCA10_X_FP97AG, 190914S_LCB3_X_16plex_Set_21

Apologies for the formatting changes, you should only look into the code of computeSCR()...

@cvanderaa cvanderaa requested a review from lgatto May 21, 2025 11:15
@lgatto lgatto merged commit fea4424 into master May 30, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants