Skip to content

Remove unneeded exception in memory.py #463

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fdxmw merged 2 commits into from
Jan 24, 2025
Merged

Remove unneeded exception in memory.py #463

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
00af73d
Remove unneeded exception from memory.py
gaborszita Jan 18, 2025
3b1c7d4
Add comment explaining why we need to call as_wires again in memory.py
gaborszita Jan 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions pyrtl/memory.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -259,10 +259,10 @@ def _build_read_port(self, addr):
def _assignment(self, item, val, is_conditional):
from .conditional import _build

item = as_wires(item, bitwidth=self.addrwidth, truncating=False)
if len(item) > self.addrwidth:
raise PyrtlError('error, the wire indexing the memory bitwidth > addrwidth')
addr = item
# Even though as_wires is already called on item already in the __getitem__ method,
# we need to call it again here because __setitem__ passes the original item
# to _assignment.
addr = as_wires(item, bitwidth=self.addrwidth, truncating=False)

if isinstance(val, MemBlock.EnabledWrite):
data, enable = val.data, val.enable
Expand Down
Loading