Skip to content

Conversation

@gaborszita
Copy link
Contributor

I changed the find_producer function in _ProducerList from a recursive implementation to an iterative one. As far as I know, recursion is not recommended in production code, especially when a simple iterative approach can achieve the same result.

@gaborszita
Copy link
Contributor Author

made a mistake in my implementation, it is still recursive, closing for now

@gaborszita gaborszita closed this Mar 6, 2025
@codecov
Copy link

codecov bot commented Mar 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.9%. Comparing base (5077c24) to head (2f2cf53).
Report is 9 commits behind head on development.

Additional details and impacted files
@@              Coverage Diff              @@
##           development    #467     +/-   ##
=============================================
+ Coverage         91.7%   91.9%   +0.3%     
=============================================
  Files               24      24             
  Lines             6403    6417     +14     
=============================================
+ Hits              5866    5892     +26     
+ Misses             537     525     -12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@gaborszita
Copy link
Contributor Author

fixed

@gaborszita gaborszita reopened this Mar 6, 2025
Copy link
Member

@fdxmw fdxmw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for cleaning this up!

@fdxmw fdxmw merged commit 2f71715 into UCSBarchlab:development Mar 6, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants