fix XOR implementation in and_inverter_synth pass and add tests
#469
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## development #469 +/- ##
=============================================
+ Coverage 92.0% 92.0% +0.1%
=============================================
Files 24 24
Lines 6470 6470
=============================================
+ Hits 5946 5951 +5
+ Misses 524 519 -5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
|
Your fix looks good to me, thanks for catching this bug! Please add a small test for |
|
We all loved your project!! |
EdwinChang24
changed the title
and_inverter_synth passand_inverter_synth pass and add tests
Contributor
Author
|
Should be good now! |
fdxmw
reviewed
Jun 19, 2025
Member
fdxmw
left a comment
fdxmw
left a comment
There was a problem hiding this comment.
There are also some pycodestyle errors in the pull request checks:
tests/test_passes.py:753:101: E501 line too long (109 > 100 characters)
tests/test_passes.py:778:101: E501 line too long (109 > 100 characters)
Contributor
Author
|
Thanks for the feedback! I've restructured the tests; hopefully I addressed everything. |
Member
|
Looks great, thanks for cleaning this up! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Maybe I shouldn't have built my project on top of an algorithm last updated nine and a half years ago...