Skip to content

Commit c967b83

Browse files
committed
[builder][INTERNAL] generateVersionInfo: Remove obsolete test
Missing options are already covered by unit test of versionInfoGenerator
1 parent 987d74d commit c967b83

File tree

1 file changed

+0
-39
lines changed

1 file changed

+0
-39
lines changed

packages/builder/test/lib/tasks/generateVersionInfo.js

Lines changed: 0 additions & 39 deletions
Original file line numberDiff line numberDiff line change
@@ -156,45 +156,6 @@ test.serial("integration: Library without i18n bundle file", async (t) => {
156156
"Cannot add meta information for library 'test.lib3'. The manifest.json file cannot be found");
157157
});
158158

159-
// MB: No idea what the below test is supposed to check, but apparently
160-
// I fixed the missing options parameter
161-
// eslint-disable-next-line ava/no-skip-test
162-
test.serial.skip("integration: Library without i18n bundle file failure", async (t) => {
163-
t.context.workspace = createWorkspace();
164-
t.context.dependencies = createDependencies();
165-
166-
t.context.resources = [];
167-
t.context.resources.push(resourceFactory.createResource({
168-
path: "/resources/test/lib/.library",
169-
string: `
170-
<?xml version="1.0" encoding="UTF-8" ?>
171-
<library xmlns="http://www.sap.com/sap.ui.library.xsd" >
172-
173-
<name>test.lib</name>
174-
<vendor>SAP SE</vendor>
175-
<copyright></copyright>
176-
<version>2.0.0</version>
177-
178-
<documentation>Test Lib</documentation>
179-
180-
</library>
181-
`,
182-
project: t.context.workspace._project
183-
}));
184-
185-
const options = {
186-
projectName: "Test Lib",
187-
pattern: "/**/*.js",
188-
rootProject: createProjectMetadata(["myname"], "1.33.7")
189-
};
190-
191-
192-
const oOptions = await createOptions(t, options);
193-
await generateVersionInfo(oOptions).catch((error) => {
194-
t.is(error.message, "[versionInfoGenerator]: Missing options parameters");
195-
});
196-
});
197-
198159
/**
199160
*
200161
* @param {module:@ui5/fs.DuplexCollection} dependencies

0 commit comments

Comments
 (0)