ci(release-please): Release please single PR #1176
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,95 @@ | ||
| name: Release Please | ||
|
|
||
| on: | ||
| push: | ||
| branches: | ||
| - main | ||
|
|
||
| permissions: | ||
| contents: write | ||
| pull-requests: write | ||
| id-token: write # Required for trusted publishing via OIDC (https://docs.npmjs.com/trusted-publishers) | ||
|
|
||
| jobs: | ||
| release-please: | ||
| runs-on: ubuntu-24.04 | ||
| steps: | ||
| - uses: actions/checkout@v5 | ||
|
|
||
| - name: Node.js LTS | ||
| uses: actions/setup-node@v5 | ||
| with: | ||
| node-version: 24.x | ||
|
|
||
| - name: Run Release Please to update PRs and create releases | ||
| uses: googleapis/release-please-action@v4 | ||
| id: release | ||
| with: | ||
| token: "${{ secrets.GITHUB_TOKEN }}" | ||
|
|
||
| publish-packages: | ||
| runs-on: ubuntu-24.04 | ||
| needs: release-please | ||
| if: needs.release-please.outputs.releases_created == 'true' | ||
| strategy: | ||
| # Publish packages in dependency order: logger → fs → builder → server → project | ||
| # CLI is handled separately to update shrinkwrap | ||
| # Order of packages in the matrix does matter and is important! | ||
| # release-please updates the package.json dependencies with ones that do not exist yet on NPM | ||
| # Publish in the correct order is important, so that dependencies are available and resolved properly! | ||
| max-parallel: 1 | ||
| matrix: | ||
| package: [logger, fs, builder, server, project] | ||
| steps: | ||
| - uses: actions/checkout@v5 | ||
|
|
||
| - name: Node.js LTS | ||
| uses: actions/setup-node@v5 | ||
| with: | ||
| node-version: 24.x | ||
|
|
||
| - name: Install and publish ${{ matrix.package }} | ||
| working-directory: packages/${{ matrix.package }} | ||
| run: | | ||
| echo "🚀 Publishing @ui5/${{ matrix.package }}" | ||
|
|
||
| # TODO: Uncomment when ready to publish | ||
| # npm ci | ||
| # npm publish --access public | ||
d3xter666 marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
|
||
| publish-cli: | ||
| runs-on: ubuntu-24.04 | ||
| needs: [release-please, publish-packages] | ||
| if: needs.release-please.outputs.releases_created == 'true' | ||
| steps: | ||
| - uses: actions/checkout@v5 | ||
|
|
||
| - name: Node.js LTS | ||
| uses: actions/setup-node@v5 | ||
| with: | ||
| node-version: 24.x | ||
|
|
||
|
|
||
| - name: Prepare production dependency tree | ||
| working-directory: packages/cli | ||
| run: | | ||
| echo "📦 Installing production dependencies for CLI" | ||
| npm ci --omit=dev | ||
| - name: Generate npm-shrinkwrap.json (prod only) | ||
|
||
| run: | | ||
| echo "🔒 Creating npm-shrinkwrap.json without devDependencies" | ||
| # Create temporary directory outside workspace for shrinkwrap generation | ||
| mkdir -p /tmp/cli-shrinkwrap | ||
| cp -r packages/cli/* /tmp/cli-shrinkwrap/ | ||
| cd /tmp/cli-shrinkwrap | ||
| rm -f npm-shrinkwrap.json | ||
| npm shrinkwrap | ||
| # Copy shrinkwrap back to CLI package | ||
| cp npm-shrinkwrap.json ${{ github.workspace }}/packages/cli/ | ||
| echo "✅ npm-shrinkwrap.json generated" | ||
| - name: Publish @ui5/cli | ||
| working-directory: packages/cli | ||
| run: | | ||
| echo "🚀 Publishing @ui5/cli" | ||
| # TODO: Uncomment when ready to publish | ||
| # npm publish --access public | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| { | ||
| "packages/logger": "4.0.2", | ||
d3xter666 marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| "packages/fs": "4.0.2", | ||
| "packages/builder": "4.0.11", | ||
| "packages/server": "4.0.7", | ||
| "packages/project": "4.0.6", | ||
| "packages/cli": "4.0.26" | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Special handling for the CLI package is required, where the shrinkwrap needs to be updated/created after all dependencies have been released. Should this be done in a separate PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
I think we had something related to the shrinkwrap itself, but I can't find the discussion/BLI!
I have updated the action so that it:
npm cifor publishing for the next package in the chain, it will have the previous package already published on NPM.As per my research this is the approach many monorepos are wokring. Lerna, for example