docs: Add release please flow and config information#1217
Conversation
Co-authored-by: Günter Klatt <57760635+KlattG@users.noreply.github.com>
Co-authored-by: Günter Klatt <57760635+KlattG@users.noreply.github.com>
Co-authored-by: Günter Klatt <57760635+KlattG@users.noreply.github.com>
Co-authored-by: Günter Klatt <57760635+KlattG@users.noreply.github.com>
Co-authored-by: Günter Klatt <57760635+KlattG@users.noreply.github.com>
Co-authored-by: Günter Klatt <57760635+KlattG@users.noreply.github.com>
Co-authored-by: Günter Klatt <57760635+KlattG@users.noreply.github.com>
Co-authored-by: Günter Klatt <57760635+KlattG@users.noreply.github.com>
Co-authored-by: Günter Klatt <57760635+KlattG@users.noreply.github.com>
Co-authored-by: Günter Klatt <57760635+KlattG@users.noreply.github.com>
Co-authored-by: Günter Klatt <57760635+KlattG@users.noreply.github.com>
Co-authored-by: Günter Klatt <57760635+KlattG@users.noreply.github.com>
Co-authored-by: Günter Klatt <57760635+KlattG@users.noreply.github.com>
Co-authored-by: Günter Klatt <57760635+KlattG@users.noreply.github.com>
Co-authored-by: Günter Klatt <57760635+KlattG@users.noreply.github.com>
Co-authored-by: Günter Klatt <57760635+KlattG@users.noreply.github.com>
Co-authored-by: Günter Klatt <57760635+KlattG@users.noreply.github.com>
Co-authored-by: Günter Klatt <57760635+KlattG@users.noreply.github.com>
Co-authored-by: Günter Klatt <57760635+KlattG@users.noreply.github.com>
Co-authored-by: Günter Klatt <57760635+KlattG@users.noreply.github.com>
Co-authored-by: Günter Klatt <57760635+KlattG@users.noreply.github.com>
Co-authored-by: Günter Klatt <57760635+KlattG@users.noreply.github.com>
Co-authored-by: Günter Klatt <57760635+KlattG@users.noreply.github.com>
Co-authored-by: Günter Klatt <57760635+KlattG@users.noreply.github.com>
Co-authored-by: Günter Klatt <57760635+KlattG@users.noreply.github.com>
Co-authored-by: Günter Klatt <57760635+KlattG@users.noreply.github.com>
Co-authored-by: Günter Klatt <57760635+KlattG@users.noreply.github.com>
Co-authored-by: Günter Klatt <57760635+KlattG@users.noreply.github.com>
Co-authored-by: Günter Klatt <57760635+KlattG@users.noreply.github.com>
Co-authored-by: Günter Klatt <57760635+KlattG@users.noreply.github.com>
Co-authored-by: Günter Klatt <57760635+KlattG@users.noreply.github.com>
Co-authored-by: Günter Klatt <57760635+KlattG@users.noreply.github.com>
Co-authored-by: Günter Klatt <57760635+KlattG@users.noreply.github.com>
Co-authored-by: Günter Klatt <57760635+KlattG@users.noreply.github.com>
Co-authored-by: Günter Klatt <57760635+KlattG@users.noreply.github.com>
Co-authored-by: Günter Klatt <57760635+KlattG@users.noreply.github.com>
Co-authored-by: Günter Klatt <57760635+KlattG@users.noreply.github.com>
Co-authored-by: Günter Klatt <57760635+KlattG@users.noreply.github.com>
Co-authored-by: Günter Klatt <57760635+KlattG@users.noreply.github.com>
Co-authored-by: Günter Klatt <57760635+KlattG@users.noreply.github.com>
docs/Release-Workflow.md
Outdated
| **Behavior**: | ||
| - Scans all `package.json` files in the workspace | ||
| - Updates `dependencies` and `devDependencies` when workspace packages are bumped | ||
| - `merge: false` updates versions, but doesn't merge PRs automatically |
There was a problem hiding this comment.
What is the source of this fact about the merge flag?
There was a problem hiding this comment.
Thanks!
I have updated it.
docs/release-workflow-diagram.drawio
Outdated
| <mxCell id="note-sequential" value="<b>Why sequential publishing?</b><br>• Packages have dependencies on each other<br>• NPM must have dependencies available<br>&nbsp;&nbsp;before publishing dependents<br>• `max-parallel: 1` ensures proper ordering" style="rounded=1;whiteSpace=wrap;html=1;fillColor=#fff9e6;strokeColor=#d6b656;dashed=1;dashPattern=3 3;align=left;spacingLeft=10;fontSize=10;" parent="1" vertex="1"> | ||
| <mxGeometry x="740" y="580" width="280" height="100" as="geometry"/> | ||
| </mxCell> | ||
| <mxCell id="note-cli" value="<b>Why CLI published last?</b><br>• Shrinkwrap needs all dependencies<br>&nbsp;&nbsp;to exist on npm registry<br>• Ensures production-only locked deps" style="rounded=1;whiteSpace=wrap;html=1;fillColor=#fff9e6;strokeColor=#d6b656;dashed=1;dashPattern=3 3;align=left;spacingLeft=10;fontSize=10;" parent="1" vertex="1"> |
There was a problem hiding this comment.
I don't fully understand the connection between Why CLI published last? and Ensures production-only locked deps. To me the order of publishing isn't linked to that detail. It rather sounds like an explanation for using npm shrinkwrap in the CLI.
There was a problem hiding this comment.
I'll try to reword it. It's maybe confusing as, but the idea is that:
- Packages must be published in a specific order, so that they are published correctly on NPM
- The shrinkwrap generator uses NPM packages, so it depends on that (all packages being available on NPM)
docs/Release-Workflow.md
Outdated
| "group-pull-request-title-pattern": "release: UI5 CLI packages ${branch}" | ||
| ``` | ||
|
|
||
| **Purpose**: Defines the title format for release pull requests in monorepos |
There was a problem hiding this comment.
I'm not sure whether we need to repeat all the release please documentation in such detail on this page.
The interesting detail about this configuration would be the fact why we can't use the ${version} placeholder for the PR title.
There was a problem hiding this comment.
I have refactored is, so now only the important information is shown
| - `merge: false` updates versions, but doesn't merge PRs automatically | ||
|
|
||
| **Known limitations**: | ||
| - Cannot resolve circular peer dependencies (e.g., `@ui5/project` ↔ `@ui5/builder`) |
There was a problem hiding this comment.
The available configuration to update peer dependencies is not mentioned here. So one could assume that it just needs to be configured to update the peer dependencies. Also, linking the existing release-please issue about this problem here would be helpful.
docs/Release-Workflow.md
Outdated
| - Types can be reordered by array position | ||
| - Hidden types are useful for internal changes (tests, CI, etc.) | ||
|
|
||
| **Documentation**: [Changelog Sections](https://github.com/googleapis/release-please?tab=readme-ov-file#changelog-sections) |
There was a problem hiding this comment.
I can't find this section when opening the link.
f71c619 to
1692e9f
Compare
JIRA: CPOUI5FOUNDATION-1166
Describes the release please workflow: #1215
Rendered document: https://github.com/UI5/cli/blob/31b5215547eeedef57bf5593d02e8fafd5a07d58/docs/Release-Workflow.md