[FIX] Use single quotes for deprecated import message (#63)

Author: matz3

packages/ui5-linter/src/detectors/typeChecker/FileLinter.ts

@@ -317,6 +317,12 @@ export default class FileLinter {
 
 	analyzeImportDeclaration(importDeclarationNode: ts.ImportDeclaration) {
 		const moduleSpecifierNode = importDeclarationNode.moduleSpecifier;
+		if (!ts.isStringLiteral(moduleSpecifierNode)) {
+			// An ImportDeclaration moduleSpecifier is of type Expression, but the docs says:
+			// "If this is not a StringLiteral it will be a grammar error."
+			// So we ignore such cases here.
+			return;
+		}
 		const symbol = this.#checker.getSymbolAtLocation(moduleSpecifierNode);
 		// Only check for the "default" export regardless of what's declared
 		// as UI5 / AMD only supports importing the default anyways.
@@ -329,7 +335,7 @@ export default class FileLinter {
 				ruleId: "ui5-linter-no-deprecated-api",
 				message:
 					`Import of deprecated module ` +
-					`${moduleSpecifierNode.getText()}`,
+					`'${moduleSpecifierNode.text}'`,
 				messageDetails: this.extractDeprecatedMessage(defaultExportSymbol),
 			});
 		}

packages/ui5-linter/test/lib/linter/rules/snapshots/NoDeprecatedApi.ts.md

@@ -19,7 +19,7 @@ Generated by [AVA](https://avajs.dev).
             column: 16,
             fatal: undefined,
             line: 1,
-            message: 'Import of deprecated module "sap/ui/model/odata/ODataModel"',
+            message: 'Import of deprecated module \'sap/ui/model/odata/ODataModel\'',
             messageDetails: 'Deprecated test message',
             ruleId: 'ui5-linter-no-deprecated-api',
             severity: 2,
@@ -44,7 +44,7 @@ Generated by [AVA](https://avajs.dev).
             column: 18,
             fatal: undefined,
             line: 2,
-            message: 'Import of deprecated module "sap/m/DateTimeInput"',
+            message: 'Import of deprecated module \'sap/m/DateTimeInput\'',
             messageDetails: 'Deprecated test message',
             ruleId: 'ui5-linter-no-deprecated-api',
             severity: 2,
@@ -53,7 +53,7 @@ Generated by [AVA](https://avajs.dev).
             column: 41,
             fatal: undefined,
             line: 2,
-            message: 'Import of deprecated module "sap/base/util/includes"',
+            message: 'Import of deprecated module \'sap/base/util/includes\'',
             messageDetails: 'Deprecated test message',
             ruleId: 'ui5-linter-no-deprecated-api',
             severity: 2,
@@ -250,7 +250,7 @@ Generated by [AVA](https://avajs.dev).
             column: 2,
             fatal: undefined,
             line: 6,
-            message: 'Import of deprecated module "sap/m/DateTimeInput"',
+            message: 'Import of deprecated module \'sap/m/DateTimeInput\'',
             messageDetails: 'Deprecated test message',
             ruleId: 'ui5-linter-no-deprecated-api',
             severity: 2,
@@ -320,7 +320,7 @@ Generated by [AVA](https://avajs.dev).
             column: 2,
             fatal: undefined,
             line: 7,
-            message: 'Import of deprecated module "sap/m/DateTimeInput"',
+            message: 'Import of deprecated module \'sap/m/DateTimeInput\'',
             messageDetails: 'Deprecated test message',
             ruleId: 'ui5-linter-no-deprecated-api',
             severity: 2,
@@ -434,7 +434,7 @@ Generated by [AVA](https://avajs.dev).
             column: 2,
             fatal: undefined,
             line: 4,
-            message: 'Import of deprecated module "sap/ui/core/Message"',
+            message: 'Import of deprecated module \'sap/ui/core/Message\'',
             messageDetails: 'Deprecated test message',
             ruleId: 'ui5-linter-no-deprecated-api',
             severity: 2,
@@ -459,7 +459,7 @@ Generated by [AVA](https://avajs.dev).
             column: 2,
             fatal: undefined,
             line: 6,
-            message: 'Import of deprecated module "sap/ui/core/Message"',
+            message: 'Import of deprecated module \'sap/ui/core/Message\'',
             messageDetails: 'Deprecated test message',
             ruleId: 'ui5-linter-no-deprecated-api',
             severity: 2,
@@ -468,7 +468,7 @@ Generated by [AVA](https://avajs.dev).
             column: 8,
             fatal: undefined,
             line: 9,
-            message: 'Import of deprecated module "sap/ui/model/odata/ODataModel"',
+            message: 'Import of deprecated module \'sap/ui/model/odata/ODataModel\'',
             messageDetails: 'Deprecated test message',
             ruleId: 'ui5-linter-no-deprecated-api',
             severity: 2,
@@ -493,7 +493,7 @@ Generated by [AVA](https://avajs.dev).
             column: 2,
             fatal: undefined,
             line: 7,
-            message: 'Import of deprecated module "sap/m/DateTimeInput"',
+            message: 'Import of deprecated module \'sap/m/DateTimeInput\'',
             messageDetails: 'Deprecated test message',
             ruleId: 'ui5-linter-no-deprecated-api',
             severity: 2,

packages/ui5-linter/test/lib/linter/rules/snapshots/NoDeprecatedApi.ts.snap

@@ -705,7 +705,7 @@ Generated by [AVA](https://avajs.dev).
             column: 2,
             fatal: undefined,
             line: 11,
-            message: 'Import of deprecated module "sap/m/MessagePage"',
+            message: 'Import of deprecated module \'sap/m/MessagePage\'',
             messageDetails: 'Deprecated test message',
             ruleId: 'ui5-linter-no-deprecated-api',
             severity: 2,