Skip to content

refactor(create_integration_card): Rename 'src' folder to 'card' #210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
flovogt merged 1 commit into from
Feb 5, 2026
Merged

refactor(create_integration_card): Rename 'src' folder to 'card' #210

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
0 resources/template-card/src/analytical.ejs → resources/template-card/card/analytical.ejs
View file
Open in desktop
File renamed without changes.
0 resources/template-card/src/calendar.ejs → resources/template-card/card/calendar.ejs
View file
Open in desktop
File renamed without changes.
0 ...ces/template-card/src/dt/Configuration.js → ...es/template-card/card/dt/Configuration.js
View file
Open in desktop
File renamed without changes.
0 ...es/template-card/src/i18n/i18n.properties → ...s/template-card/card/i18n/i18n.properties
View file
Open in desktop
File renamed without changes.
0 resources/template-card/src/list.ejs → resources/template-card/card/list.ejs
View file
Open in desktop
File renamed without changes.
0 resources/template-card/src/manifest.json → resources/template-card/card/manifest.json
View file
Open in desktop
File renamed without changes.
0 resources/template-card/src/object.ejs → resources/template-card/card/object.ejs
View file
Open in desktop
File renamed without changes.
0 resources/template-card/src/table.ejs → resources/template-card/card/table.ejs
View file
Open in desktop
File renamed without changes.
0 resources/template-card/src/timeline.ejs → resources/template-card/card/timeline.ejs
View file
Open in desktop
File renamed without changes.
2 changes: 1 addition & 1 deletion resources/template-card/test/App.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ sap.ui.define(["sap/ui/integration/Host"], async (Host) => {
});

card.host = host.getId();
card.manifest = "../src/manifest.json";
card.manifest = "../card/manifest.json";

editor.host = host.getId();
editor.card = "card";
Expand Down
0 ...n_card/Analytical/src/dt/Configuration.js → ..._card/Analytical/card/dt/Configuration.js
View file
Open in desktop
File renamed without changes.
0 ..._card/Analytical/src/i18n/i18n.properties → ...card/Analytical/card/i18n/i18n.properties
View file
Open in desktop
File renamed without changes.
0 ...gration_card/Analytical/src/manifest.json → ...ration_card/Analytical/card/manifest.json
View file
Open in desktop
File renamed without changes.
0 ...ion_card/Calendar/src/dt/Configuration.js → ...on_card/Calendar/card/dt/Configuration.js
View file
Open in desktop
File renamed without changes.
0 ...on_card/Calendar/src/i18n/i18n.properties → ...n_card/Calendar/card/i18n/i18n.properties
View file
Open in desktop
File renamed without changes.
0 ...tegration_card/Calendar/src/manifest.json → ...egration_card/Calendar/card/manifest.json
View file
Open in desktop
File renamed without changes.
0 ...gration_card/List/src/dt/Configuration.js → ...ration_card/List/card/dt/Configuration.js
View file
Open in desktop
File renamed without changes.
0 ...ration_card/List/src/i18n/i18n.properties → ...ation_card/List/card/i18n/i18n.properties
View file
Open in desktop
File renamed without changes.
0 ...e_integration_card/List/src/manifest.json → ..._integration_card/List/card/manifest.json
View file
Open in desktop
File renamed without changes.
0 ...ation_card/Object/src/dt/Configuration.js → ...tion_card/Object/card/dt/Configuration.js
View file
Open in desktop
File renamed without changes.
0 ...tion_card/Object/src/i18n/i18n.properties → ...ion_card/Object/card/i18n/i18n.properties
View file
Open in desktop
File renamed without changes.
0 ...integration_card/Object/src/manifest.json → ...ntegration_card/Object/card/manifest.json
View file
Open in desktop
File renamed without changes.
0 ...ration_card/Table/src/dt/Configuration.js → ...ation_card/Table/card/dt/Configuration.js
View file
Open in desktop
File renamed without changes.
0 ...ation_card/Table/src/i18n/i18n.properties → ...tion_card/Table/card/i18n/i18n.properties
View file
Open in desktop
File renamed without changes.
0 ..._integration_card/Table/src/manifest.json → ...integration_card/Table/card/manifest.json
View file
Open in desktop
File renamed without changes.
0 ...ion_card/Timeline/src/dt/Configuration.js → ...on_card/Timeline/card/dt/Configuration.js
View file
Open in desktop
File renamed without changes.
0 ...on_card/Timeline/src/i18n/i18n.properties → ...n_card/Timeline/card/i18n/i18n.properties
View file
Open in desktop
File renamed without changes.
0 ...tegration_card/Timeline/src/manifest.json → ...egration_card/Timeline/card/manifest.json
View file
Open in desktop
File renamed without changes.
2 changes: 1 addition & 1 deletion test/expected/create_integration_card/common/test/App.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ sap.ui.define(["sap/ui/integration/Host"], async (Host) => {
});

card.host = host.getId();
card.manifest = "../src/manifest.json";
card.manifest = "../card/manifest.json";

editor.host = host.getId();
editor.card = "card";
Expand Down
10 changes: 5 additions & 5 deletions test/lib/tools/create_integration_card/create_integration_card.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,8 +60,8 @@ test.beforeEach(async (t) => {

// Stub globby to return a fixed set of files
t.context.staticFiles = [
"src/manifest.json",
"src/i18n/i18n.properties",
"card/manifest.json",
"card/i18n/i18n.properties",
"test/index.html",
];
t.context.globbyStub = t.context.sinon.stub().resolves(t.context.staticFiles);
Expand Down Expand Up @@ -114,8 +114,8 @@ test("createIntegrationCard executes successfully", async (t) => {

t.is(mkdirStub.callCount, 4);
t.deepEqual(mkdirStub.getCall(0).args, [folderPath, {recursive: true}]);
t.deepEqual(mkdirStub.getCall(1).args, [`${folderPath}/src`.replace(/\//g, path.sep), {recursive: true}]);
t.deepEqual(mkdirStub.getCall(2).args, [`${folderPath}/src/i18n`.replace(/\//g, path.sep), {recursive: true}]);
t.deepEqual(mkdirStub.getCall(1).args, [`${folderPath}/card`.replace(/\//g, path.sep), {recursive: true}]);
t.deepEqual(mkdirStub.getCall(2).args, [`${folderPath}/card/i18n`.replace(/\//g, path.sep), {recursive: true}]);
t.deepEqual(mkdirStub.getCall(3).args, [`${folderPath}/test`.replace(/\//g, path.sep), {recursive: true}]);

// Verify that globby was called with correct parameters
Expand Down Expand Up @@ -218,7 +218,7 @@ test("Error processing template file", async (t) => {
manifestVersion: "1.78.0",
});
}, {
message: `Failed to process template file 'src/manifest.json': ${errorMessage}`,
message: `Failed to process template file 'card/manifest.json': ${errorMessage}`,
instanceOf: Error,
});
});
36 changes: 18 additions & 18 deletions ...ols/create_integration_card/snapshots/create_integration_card.integration.ts.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,10 +9,10 @@ Generated by [AVA](https://avajs.dev).
> Result of createIntegrationCard should match expected structure

[
'card/dt/Configuration.js',
'card/i18n/i18n.properties',
'card/manifest.json',
'package.json',
'src/dt/Configuration.js',
'src/i18n/i18n.properties',
'src/manifest.json',
'test/App.js',
'test/index.css',
'test/index.html',
Expand All @@ -23,10 +23,10 @@ Generated by [AVA](https://avajs.dev).
> Result of createIntegrationCard should match expected structure

[
'card/dt/Configuration.js',
'card/i18n/i18n.properties',
'card/manifest.json',
'package.json',
'src/dt/Configuration.js',
'src/i18n/i18n.properties',
'src/manifest.json',
'test/App.js',
'test/index.css',
'test/index.html',
Expand All @@ -37,10 +37,10 @@ Generated by [AVA](https://avajs.dev).
> Result of createIntegrationCard should match expected structure

[
'card/dt/Configuration.js',
'card/i18n/i18n.properties',
'card/manifest.json',
'package.json',
'src/dt/Configuration.js',
'src/i18n/i18n.properties',
'src/manifest.json',
'test/App.js',
'test/index.css',
'test/index.html',
Expand All @@ -51,10 +51,10 @@ Generated by [AVA](https://avajs.dev).
> Result of createIntegrationCard should match expected structure

[
'card/dt/Configuration.js',
'card/i18n/i18n.properties',
'card/manifest.json',
'package.json',
'src/dt/Configuration.js',
'src/i18n/i18n.properties',
'src/manifest.json',
'test/App.js',
'test/index.css',
'test/index.html',
Expand All @@ -65,10 +65,10 @@ Generated by [AVA](https://avajs.dev).
> Result of createIntegrationCard should match expected structure

[
'card/dt/Configuration.js',
'card/i18n/i18n.properties',
'card/manifest.json',
'package.json',
'src/dt/Configuration.js',
'src/i18n/i18n.properties',
'src/manifest.json',
'test/App.js',
'test/index.css',
'test/index.html',
Expand All @@ -79,10 +79,10 @@ Generated by [AVA](https://avajs.dev).
> Result of createIntegrationCard should match expected structure

[
'card/dt/Configuration.js',
'card/i18n/i18n.properties',
'card/manifest.json',
'package.json',
'src/dt/Configuration.js',
'src/i18n/i18n.properties',
'src/manifest.json',
'test/App.js',
'test/index.css',
'test/index.html',
Expand Down
Binary file modified test/lib/tools/create_integration_card/snapshots/create_integration_card.integration.ts.snap
View file
Open in desktop
Binary file not shown.