Skip to content

Commit 9949491

Browse files
SvBeGerrit Code Review
authored andcommitted
Merge "[INTERNAL] sap.ui.core.sample.odata.v4.SalesOrders: remove obsolete properties"
2 parents 58db520 + e163b13 commit 9949491

File tree

3 files changed

+6
-14
lines changed

3 files changed

+6
-14
lines changed

src/sap.ui.core/test/sap/ui/core/demokit/sample/odata/v4/SalesOrders/Component.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -91,7 +91,6 @@ sap.ui.define([
9191
"sap.ui.core.sample.odata.v4.SalesOrders.Component");
9292

9393
this.oUiModel = new JSONModel({
94-
bCreateItemPending : false,
9594
filterProductID : "",
9695
filterValue : "",
9796
itemFilter : aItemFilter,

src/sap.ui.core/test/sap/ui/core/demokit/sample/odata/v4/SalesOrders/Main.controller.js

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -21,8 +21,6 @@ sap.ui.define([
2121
sServiceNamespace = "com.sap.gateway.default.zui5_epm_sample.v0002.";
2222

2323
return Controller.extend("sap.ui.core.sample.odata.v4.SalesOrders.Main", {
24-
iTransientItems : 0,
25-
2624
formatAddress : function (oAddress) {
2725
return oAddress
2826
? `${oAddress.Street} ${oAddress.Building}`
@@ -189,7 +187,7 @@ sap.ui.define([
189187
oTable.getItems()[0].focus();
190188

191189
// Note: this promise fails only if the transient entity is delete or canceled
192-
this.oSalesOrderLineItemCreated = oContext.created().then(function () {
190+
oContext.created().then(function () {
193191
var oItem = oTable.getSelectedItem();
194192

195193
MessageBox.success("Line item created: " + oContext.getProperty("ItemPosition"));

src/sap.ui.core/test/sap/ui/core/demokit/sample/odata/v4/SalesOrders/Main.view.xml

Lines changed: 5 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -129,8 +129,7 @@
129129
dataRequested : '.onDataEvents'
130130
}
131131
}"
132-
mode="{= ${ui>/bCreateItemPending} ? 'None' : 'SingleSelectMaster' }"
133-
selectionChange=".onSalesOrdersSelect">
132+
mode="SingleSelectMaster" selectionChange=".onSalesOrdersSelect">
134133
<dependents>
135134
<plugins:DataStateIndicator/>
136135
</dependents>
@@ -142,8 +141,7 @@
142141
<ToolbarLayoutData shrinkable="false"/>
143142
</layoutData>
144143
</Title>
145-
<Button enabled="{!${ui>/bCreateItemPending}"
146-
icon="sap-icon://add" id="createSalesOrder" press=".onCreateSalesOrder"
144+
<Button icon="sap-icon://add" id="createSalesOrder" press=".onCreateSalesOrder"
147145
tooltip="Create sales order"/>
148146
<Button
149147
enabled="{= ${ui>/bSalesOrderSelected} }"
@@ -152,15 +150,13 @@
152150
tooltip="Delete selected sales order"/>
153151
<Button
154152
enabled="{= ${ui>/bSalesOrderSelected}
155-
&amp;&amp; !${ui>/bSelectedSalesOrderTransient}
156-
&amp;&amp; !${ui>/bCreateItemPending} }"
153+
&amp;&amp; !${ui>/bSelectedSalesOrderTransient} }"
157154
icon="sap-icon://synchronize"
158155
id="refreshSelectedSalesOrder" press=".onRefreshSelectedSalesOrder"
159156
tooltip="Refresh selected sales order"/>
160157
<Button
161158
enabled="{= ${ui>/bSalesOrderSelected}
162-
&amp;&amp; !${ui>/bSelectedSalesOrderTransient}
163-
&amp;&amp; !${ui>/bCreateItemPending} }"
159+
&amp;&amp; !${ui>/bSelectedSalesOrderTransient} }"
164160
id="confirmSalesOrder"
165161
icon="sap-icon://accept"
166162
press=".onConfirmSalesOrder" tooltip="Confirm selected sales order"/>
@@ -172,8 +168,7 @@
172168
tooltip="Reset changes for selected sales order"/>
173169
<Button
174170
enabled="{= ${ui>/bSalesOrderSelected}
175-
&amp;&amp; !${ui>/bSelectedSalesOrderTransient}
176-
&amp;&amp; !${ui>/bCreateItemPending} }"
171+
&amp;&amp; !${ui>/bSelectedSalesOrderTransient} }"
177172
id="openSimulateDiscountDialog"
178173
icon="sap-icon://simulate"
179174
press=".onOpenSimulateDiscountDialog"

0 commit comments

Comments
 (0)