Skip to content

docs(FilterBar): include selection in With Logic story #6973

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Lukas742 merged 1 commit into from
Feb 20, 2025
Merged

docs(FilterBar): include selection in With Logic story #6973

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
50 changes: 42 additions & 8 deletions packages/main/src/components/FilterBar/FilterBar.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ import { FlexBox } from '../FlexBox/index.js';
import { Text } from '../Text/index.js';
import { VariantManagement } from '../VariantManagement/index.js';
import { VariantItem } from '../VariantManagement/VariantItem.js';
import type { FilterBarPropTypes } from './index.js';
import { FilterBar } from './index.js';

const meta = {
Expand Down Expand Up @@ -137,7 +138,8 @@ const initialState = {
currency: 'USD',
date: '',
dateRange: '',
search: ''
search: '',
selectedFiltersByLabel: ['Age', 'Countries', 'Currency', 'Date']
};

function reducer(state, action) {
Expand All @@ -154,6 +156,16 @@ function reducer(state, action) {
return { ...state, dateRange: action.payload };
case 'SET_SEARCH':
return { ...state, search: action.payload };
case 'SHOW_FILTER': {
const updatedFilters = new Set(state.selectedFiltersByLabel);
updatedFilters.add(action.payload);
return { ...state, selectedFiltersByLabel: Array.from(updatedFilters) };
}
case 'HIDE_FILTER': {
const updatedFilters = new Set(state.selectedFiltersByLabel);
updatedFilters.delete(action.payload);
return { ...state, selectedFiltersByLabel: Array.from(updatedFilters) };
}
case 'DIALOG_RESTORE':
return action.payload;
default:
Expand All @@ -164,7 +176,7 @@ function reducer(state, action) {
export const WithLogic: Story = {
render: (args) => {
const [state, dispatch] = useReducer(reducer, initialState);
const { age, countries, currency, date, dateRange, search } = state;
const { age, countries, currency, date, dateRange, search, selectedFiltersByLabel } = state;
const prevDialogOpenState = useRef();

const handleSearch = (e) => {
Expand Down Expand Up @@ -206,18 +218,32 @@ export const WithLogic: Story = {
dispatch({ type: 'DIALOG_RESTORE', payload: prevDialogOpenState.current });
};

const handleFilterSelectionChange: FilterBarPropTypes['onFiltersDialogSelectionChange'] = (e) => {
const { checked, element } = e.detail;
if (checked) {
dispatch({ type: 'SHOW_FILTER', payload: element.dataset.text });
} else {
dispatch({ type: 'HIDE_FILTER', payload: element.dataset.text });
}
};

return (
<>
<FilterBar
showResetButton
search={<Input onInput={handleSearch} />}
onRestore={handleRestore}
onFiltersDialogOpen={handleFiltersDialogOpen}
onFiltersDialogSelectionChange={handleFilterSelectionChange}
>
<FilterGroupItem label="Age" active={!!age} required>
<StepInput value={age} onChange={handleAgeChange} required />
</FilterGroupItem>
<FilterGroupItem label="Countries" active={Object.keys(countries).length > 0}>
<FilterGroupItem
label="Countries"
active={Object.keys(countries).length > 0}
visibleInFilterBar={selectedFiltersByLabel.includes('Countries')}
>
<MultiComboBox onSelectionChange={handleCountriesChange}>
<MultiComboBoxItem text="Argentina" selected={countries.argentina} />
<MultiComboBoxItem text="Bulgaria" selected={countries.bulgaria} />
Expand All @@ -228,7 +254,11 @@ export const WithLogic: Story = {
<MultiComboBoxItem text="USA" selected={countries.usa} />
</MultiComboBox>
</FilterGroupItem>
<FilterGroupItem label="Currency" active={!!currency}>
<FilterGroupItem
label="Currency"
active={!!currency}
visibleInFilterBar={selectedFiltersByLabel.includes('Currency')}
>
<Select onChange={handleCurrencyChange}>
<Option additionalText="€" selected={currency === 'EUR'}>
EUR
Expand All @@ -247,11 +277,15 @@ export const WithLogic: Story = {
</Option>
</Select>
</FilterGroupItem>
<FilterGroupItem label="Date" active={!!date}>
<DatePicker value={date} onChange={handleDateChange} style={{ minWidth: 'auto' }} on />
<FilterGroupItem label="Date" active={!!date} visibleInFilterBar={selectedFiltersByLabel.includes('Date')}>
<DatePicker value={date} onChange={handleDateChange} style={{ minWidth: 'auto' }} />
</FilterGroupItem>
<FilterGroupItem label="Date Range" active={!!dateRange} visibleInFilterBar={false}>
<DateRangePicker value={dateRange} onChange={handleDateRangeChange} style={{ minWidth: 'auto' }} on />
<FilterGroupItem
label="Date Range"
active={!!dateRange}
visibleInFilterBar={selectedFiltersByLabel.includes('Date Range')}
>
<DateRangePicker value={dateRange} onChange={handleDateRangeChange} style={{ minWidth: 'auto' }} />
</FilterGroupItem>
</FilterBar>
<FlexBox direction={FlexBoxDirection.Column}>
Expand Down
Loading