Skip to content

refactor: set an explicit value for aria-hidden #7182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Lukas742 merged 3 commits into from
Apr 7, 2025
Merged

refactor: set an explicit value for aria-hidden #7182

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6940fc7
refactor: set an explicit value for `aria-hidden`
Lukas742 Apr 3, 2025
b97283f
Merge branch 'main' into refactor/aria-hidden
Lukas742 Apr 4, 2025
db04947
Merge branch 'main' into refactor/aria-hidden
Lukas742 Apr 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/main/src/components/FilterGroupItem/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -259,7 +259,7 @@ const FilterGroupItem = forwardRef<HTMLDivElement, FilterGroupItemPropTypes & Fi
)}
{active && (
<>
<Icon name={circleTask2Icon} className={classNames.dialogActiveIcon} aria-hidden />
<Icon name={circleTask2Icon} className={classNames.dialogActiveIcon} aria-hidden="true" />
<span className={classNames.pseudoInvisibleText}>{i18nBundle.getText(FILTER_IS_ACTIVE)}</span>
</>
)}
Expand Down
6 changes: 3 additions & 3 deletions packages/main/src/components/ObjectPage/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -717,13 +717,13 @@ const ObjectPage = forwardRef<ObjectPageDomRef, ObjectPagePropTypes>((props, ref
? `${headerContentHeight}px`
: 0
}}
aria-hidden
aria-hidden="true"
/>
{placeholder ? placeholder : sections}
<div style={{ height: `${sectionSpacer}px` }} aria-hidden />
<div style={{ height: `${sectionSpacer}px` }} aria-hidden="true" />
</div>
{footerArea && mode === ObjectPageMode.IconTabBar && !sectionSpacer && (
<div className={classNames.footerSpacer} data-component-name="ObjectPageFooterSpacer" aria-hidden />
<div className={classNames.footerSpacer} data-component-name="ObjectPageFooterSpacer" aria-hidden="true" />
)}
{footerArea && (
<footer
Expand Down
2 changes: 1 addition & 1 deletion packages/main/src/components/ObjectPageTitle/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,7 +175,7 @@ const ObjectPageTitle = forwardRef<HTMLDivElement, ObjectPageTitlePropTypes>((pr
<div
className={classNames.actionsSeparator}
data-component-name="ObjectPageTitleActionsSeparator"
aria-hidden
aria-hidden="true"
/>
)}
{!showNavigationInTopArea && (wcrNavToolbar ? wcrNavToolbar : navigationBar)}
Expand Down
2 changes: 1 addition & 1 deletion packages/main/src/components/ObjectStatus/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -200,7 +200,7 @@ const ObjectStatus = forwardRef<HTMLDivElement | HTMLButtonElement, ObjectStatus
const showEmptyIndicator = emptyIndicator && !children;
const computedChildren = showEmptyIndicator ? (
<span
aria-hidden={showEmptyIndicator}
aria-hidden={showEmptyIndicator ? 'true' : undefined}
data-component-name="ObjectStatusEmptyIndicator"
className={classNames.emptyIndicator}
>
Expand Down
Loading