chore(ui5-navigation-layout): add constant for the screen width #12857
+6
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TeodorTaushanov
approved these changes
Jan 7, 2026
Collaborator
|
🧹 Preview deployment cleaned up: https://pr-12857--ui5-webcomponents.netlify.app |
Stoev
reviewed
Jan 7, 2026
Stoev
left a comment
Stoev
left a comment
There was a problem hiding this comment.
Header is fine, no suggestions for human language in files. The "//" comment is a bit fuzzy, but since it's not part of docu it seems it can stay as it is.
If you want to be more precise maybe add below header something like:
Replace hard‑coded 600px with SCREEN_WIDTH_BREAKPOINT.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace hard‑coded 600px with SCREEN_WIDTH_BREAKPOINT
Jira: 3570