Skip to content

chore(ui5-navigation-layout): add constant for the screen width #12857

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
LidiyaGeorgieva merged 1 commit into from
Jan 7, 2026
+6 −3
Merged

chore(ui5-navigation-layout): add constant for the screen width #12857

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion packages/fiori/src/NavigationLayout.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,8 @@ import NavigationLayoutTemplate from "./NavigationLayoutTemplate.js";
// Styles
import NavigationLayoutCss from "./generated/themes/NavigationLayout.css.js";

const SCREEN_WIDTH_BREAKPOINT = 600;

/**
* @class
*
Expand Down Expand Up @@ -49,7 +51,7 @@ import NavigationLayoutCss from "./generated/themes/NavigationLayout.css.js";
template: NavigationLayoutTemplate,
})
class NavigationLayout extends UI5Element {
_defaultSideCollapsed = window.innerWidth < 600; // Small screens (599px or less)
_defaultSideCollapsed = window.innerWidth < SCREEN_WIDTH_BREAKPOINT;

/**
* Specifies the navigation layout mode.
Expand Down
3 changes: 2 additions & 1 deletion packages/fiori/src/SideNavigation.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@ import SideNavigationCss from "./generated/themes/SideNavigation.css.js";
import SideNavigationPopoverCss from "./generated/themes/SideNavigationPopover.css.js";

const PAGE_UP_DOWN_SIZE = 10;
const SCREEN_WIDTH_BREAKPOINT = 600;

type SideNavigationPopoverContents = {
item: SideNavigationItem,
Expand Down Expand Up @@ -483,7 +484,7 @@ class SideNavigation extends UI5Element {

handleResize() {
// In smaller screen the side navigation hidden when collapsed and there is no overflow items
if (window.innerWidth > 600) {
if (window.innerWidth > SCREEN_WIDTH_BREAKPOINT) {
this._updateOverflowItems();
}
}
Expand Down
2 changes: 1 addition & 1 deletion packages/fiori/src/types/NavigationLayoutMode.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
*/
enum NavigationLayoutMode {
/**
* Automatically calculates the navigation layout mode based on the screen device type.
* Automatically calculates the navigation layout mode based on the screen width.
* `Collapsed` on small screens (screen width of 599px or less) and `Expanded` on larger screens (screen width of 600px or more).
* @public
*/
Expand Down
Loading