-
Notifications
You must be signed in to change notification settings - Fork 277
chore: improve input value handling #10935
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
pskelin
wants to merge
19
commits into
main
Choose a base branch
from
input-value-old
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…SX and UI5CustomEvent
Collaborator
|
🚀 Deployed on https://pr-10935--ui5-webcomponents-preview.netlify.app |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
<ui5-input>has a very complex logic for handlingtype=numeric, implemented by keeping_innerValue.This has two issues:
preactto render a value in the DOM only when it is different from the old value.This fix remove the preact patch returning it to default - if a value is set in the tempate, it will be set in the DOM (for native inputs this will always assign a value from the state, even if it is the same)
By removing the
_innverValue, apps can automatically set an old value and it will propagate in the DOM.Example before - an input that accepts only three numbers by setting the old value if more than three numbers arrive
Example after - when setting an old value, it will be updated in the inner input, so typing
1234will correctly result in123both in.valueproperty and in DOM.see
Input_old_value.htmlfor example code