fix(ui5-popover): render block layers in the correct order #12659
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OpenUI5 dialogs' and the WebC dialogs' block layers are rendered in order Fixes: 12444
Collaborator
|
🧹 Preview deployment cleaned up: https://pr-12659--ui5-webcomponents.netlify.app |
Fixes failing test
Stoev
reviewed
Nov 13, 2025
Stoev
left a comment
Stoev
left a comment
There was a problem hiding this comment.
OpenUI5 dialogs' and the Web Components dialogs' block layers are rendered and displayed in the order of opened dialogs.
Updates samples and tests
alexandar-mitsev
requested changes
Nov 27, 2025
Member
alexandar-mitsev
left a comment
alexandar-mitsev
left a comment
There was a problem hiding this comment.
- when you start from "Open WebC Dialog" and reach to the "Web Component Dialog 2". Press on "Open UI5 Popover" - the focus moves to the "Web Component Dialog 1". See attached image
Member
|
alexandar-mitsev
requested changes
Dec 5, 2025
Addressed code review comments
alexandar-mitsev
approved these changes
Dec 8, 2025
Collaborator
|
🎉 This PR is included in version v2.18.0-rc.0 🎉 The release is available on v2.18.0-rc.0 Your semantic-release bot 📦🚀 |
Collaborator
|
🎉 This PR is included in version v2.18.0 🎉 The release is available on v2.18.0 Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OpenUI5 dialogs' and the Web Components dialogs' block layers are rendered and displayed in the order of opened dialogs.
Fixes: #12444