fix(ui5-table): accessibility improvements implemented#12684
Merged
Conversation
Collaborator
|
🧹 Preview deployment cleaned up: https://pr-12684--ui5-webcomponents.netlify.app |
simlin
approved these changes
Nov 18, 2025
aborjinik
force-pushed
the
table-custom-announcement-fixes
branch
from
90eab2f to
65bb0a0
Compare
aborjinik
commented
Nov 20, 2025
|
|
||
| const updateInvisibleText = (element: HTMLElement, text: string | string[] = []) => { | ||
| const invisibleTextId = "ui5-table-invisible-text"; | ||
| const updateInvisibleText = (element: any, text: string | string[] = []) => { |
Contributor
Author
There was a problem hiding this comment.
@ilhan007 because of the use of ariaLabelledByElements below, the TypeScript version we are using does not recognize it, and yarn start fires an error when I use the HTMLElement type. Can the framework handle this?
https://developer.mozilla.org/en-US/docs/Web/API/Element/ariaLabelledByElements
Collaborator
|
🎉 This PR is included in version v2.17.0-rc.4 🎉 The release is available on v2.17.0-rc.4 Your semantic-release bot 📦🚀 |
Collaborator
|
🎉 This PR is included in version v2.17.0 🎉 The release is available on v2.17.0 Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The correct npm package name is used for the translations
Fixes: [localization]: Jaws uses English localization in the table even though German is set as the language. #12630
For shadowDom elements ariaLabelledByElements is used instead of aria-labelledby
Fixes: [A11y][SF][Table]: The chevron (>) elements column lack alternate text. #12657
The growing sample now uses correct mode=Scroll property instead of the old type property
Fixes: [Table]: [For growing table, load more button is displayed even if the data is completely loaded in first time] #11946