Skip to content

fix(ui5-search-field): correct bg and text colors #12732

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MapTo0 merged 3 commits into from
Jan 23, 2026
Merged

fix(ui5-search-field): correct bg and text colors #12732

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fce9837
fix(ui5-search-field): correct bg and text colors
MapTo0 Nov 27, 2025
d6ba4a6
Merge remote-tracking branch 'origin/main' into search-theming-bug
MapTo0 Jan 22, 2026
4fa8dad
fix: adjust fiori themes
MapTo0 Jan 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions packages/fiori/src/themes/SearchField.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,16 +12,15 @@
max-width: 36rem;
margin: 0;
height: 2.25rem;
color: var(--sapShell_TextColor);
color: var(--sapField_TextColor);
Copy link
Contributor

@StefanDimitrov04 StefanDimitrov04 Dec 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In fiori 3 the text is hard to see because it currently uses --sapField_TextColor (which resolves to a dark color, #232629).
According to the spec, the search should use --sapShell_InteractiveTextColor (#d1e8ff) so it remains readable.

font-size: var(--sapFontSize);
font-family: var(--sapFontFamily);
font-style: normal;
box-shadow: var(--sapField_Shadow);
border-radius: var(--_ui5_search_input_border_radius);
box-sizing: border-box;
text-align: start;
background: var(--sapField_BackgroundStyle);
background-color: var(--_ui5-search-wrapper-background);
background: var(--_ui5-search-wrapper-background);
position: relative;
}

Expand Down
2 changes: 1 addition & 1 deletion packages/fiori/src/themes/sap_fiori_3/SearchField-parameters.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
--_ui5_search_icon_border_radius: 0.375rem;
--_ui5_search_input_border_radius: none;
--_ui5-search-border: var(--sapField_BorderWidth) var(--sapField_BorderStyle) var(--sapField_BorderColor);
--_ui5-search-wrapper-background: none;
--_ui5-search-wrapper-background: var(--sapShellColor);
--_ui5_search_separator_background: none;
--_ui5-search-wrapper-hover-background: none;
--_ui5-search-wrapper-hover-background-color: none;
Expand Down
2 changes: 1 addition & 1 deletion packages/fiori/src/themes/sap_fiori_3_dark/SearchField-parameters.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
--_ui5_search_icon_border_radius: 0.375rem;
--_ui5_search_input_border_radius: none;
--_ui5-search-border: var(--sapField_BorderWidth) var(--sapField_BorderStyle) var(--sapField_BorderColor);
--_ui5-search-wrapper-background: none;
--_ui5-search-wrapper-background: var(--sapShellColor);
--_ui5_search_separator_background: none;
--_ui5-search-wrapper-hover-background: none;
--_ui5-search-wrapper-hover-background-color: none;
Expand Down
2 changes: 1 addition & 1 deletion packages/fiori/src/themes/sap_fiori_3_hcb/SearchField-parameters.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
--_ui5_search_icon_border_radius: 0.375rem;
--_ui5_search_input_border_radius: none;
--_ui5-search-border: var(--sapField_BorderWidth) var(--sapField_BorderStyle) var(--sapField_BorderColor);
--_ui5-search-wrapper-background: none;
--_ui5-search-wrapper-background: var(--sapShellColor);
--_ui5_search_separator_background: none;
--_ui5-search-wrapper-hover-background: none;
--_ui5-search-wrapper-hover-background-color: none;
Expand Down
2 changes: 1 addition & 1 deletion packages/fiori/src/themes/sap_fiori_3_hcw/SearchField-parameters.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
--_ui5_search_icon_border_radius: 0.375rem;
--_ui5_search_input_border_radius: none;
--_ui5-search-border: var(--sapField_BorderWidth) var(--sapField_BorderStyle) var(--sapField_BorderColor);
--_ui5-search-wrapper-background: none;
--_ui5-search-wrapper-background: var(--sapShellColor);
--_ui5_search_separator_background: none;
--_ui5-search-wrapper-hover-background: none;
--_ui5-search-wrapper-hover-background-color: none;
Expand Down
Loading