Skip to content

chore(ui5-input/multi-input, ui5-combobox/multi-combobox, ui5-textarea): extend form-validity tests #12733

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aleksandar-terziev merged 2 commits into from
Dec 8, 2025
Merged

chore(ui5-input/multi-input, ui5-combobox/multi-combobox, ui5-textarea): extend form-validity tests #12733

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7d5e769
chore(ui5-input/multi-input,ui5-combobox/multi-combobox,ui5-textarea)…
StefanDimitrov04 Nov 27, 2025
459f7b5
Merge branch 'main' into form-validation-comps
aleksandar-terziev Dec 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
90 changes: 72 additions & 18 deletions packages/main/cypress/specs/ComboBox.cy.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ describe("General Interaction", () => {

cy.get("@combobox").should("have.prop", "value", "One");
cy.get("[ui5-cb-item]").first().should("have.prop", "selected", true);

cy.window().then(window => {
return window.getSelection()?.toString();
}).should("contains", "ne");
Expand Down Expand Up @@ -921,7 +921,7 @@ describe("Accessibility", () => {
// open the popover
cy.get("@combo").shadow().find("input").realPress("F4");
cy.get("@combo").shadow().find("input").realPress("ArrowDown");

cy.get("@invisibleMessageSpan").should("have.text", "List item 2 of 6");
});

Expand Down Expand Up @@ -1257,14 +1257,14 @@ describe("Additional Navigation", () => {
const scrollableRect = picker[0].shadowRoot.querySelector(".ui5-popup-content").getBoundingClientRect();
const lastItem = document.querySelector("#combo-grouping ui5-cb-item-group:last-child ui5-cb-item:last-child");
const elementRect = lastItem!.getBoundingClientRect();

const isInVisibleArea = !(
elementRect.bottom < scrollableRect.top ||
elementRect.top > scrollableRect.bottom ||
elementRect.right < scrollableRect.left ||
elementRect.left > scrollableRect.right
);

expect(isInVisibleArea).to.be.true;
});

Expand All @@ -1279,14 +1279,14 @@ describe("Additional Navigation", () => {
const scrollableRect = picker[0].shadowRoot.querySelector(".ui5-popup-content").getBoundingClientRect();
const firstItem = document.querySelector("#combo-grouping ui5-cb-item-group:first-child ui5-cb-item:first-child");
const elementRect = firstItem!.getBoundingClientRect();

const isInVisibleArea = !(
elementRect.bottom < scrollableRect.top ||
elementRect.top > scrollableRect.bottom ||
elementRect.right < scrollableRect.left ||
elementRect.left > scrollableRect.right
);

expect(isInVisibleArea).to.be.true;
});
});
Expand Down Expand Up @@ -1398,7 +1398,7 @@ describe("Keyboard interaction", () => {

cy.get("#combo-grouping").shadow().find("input").realClick();
cy.get("#combo-grouping").should("be.focused");

cy.get("#combo-grouping").shadow().find("input").realClick();
cy.get("#combo-grouping").should("be.focused");

Expand Down Expand Up @@ -1922,7 +1922,7 @@ describe("Event firing", () => {

// Focus out to trigger change event
cy.get("body").realClick();

cy.get("@changeSpy").should('have.been.calledOnce');
cy.get("@changeSpy").should('have.been.calledWithMatch', Cypress.sinon.match(event => {
return event.target.value === "Algeria";
Expand Down Expand Up @@ -1997,7 +1997,7 @@ describe("Event firing", () => {

// Verify change event was fired
cy.get("@changeSpy").should('have.callCount', 1);

// Verify the event contains correct data
cy.get("@changeSpy").should('have.been.calledWithMatch', Cypress.sinon.match(event => {
return event.target.value === "Bahrain";
Expand Down Expand Up @@ -2106,11 +2106,11 @@ describe("Event firing", () => {

cy.get("@combo").shadow().find("[ui5-icon]").realClick();
cy.get("@combo").shadow().find("[inner-input]").realPress("ArrowDown");

cy.get("@changeSpy").should('have.callCount', 0);

cy.get("@combo").find("[ui5-cb-item]").first().realClick();

cy.get("@changeSpy").should('have.been.calledOnce');
cy.get("@changeSpy").should('have.been.calledWithMatch', Cypress.sinon.match(event => {
return event.target.value === "Algeria";
Expand All @@ -2131,7 +2131,7 @@ describe("Event firing", () => {

cy.get("#change-cb").shadow().find("[inner-input]").realClick();
cy.get("#change-cb").shadow().find("[inner-input]").realPress("ArrowDown");

cy.get("@changeSpy").should('have.callCount', 0);

cy.get("#change-cb").shadow().find("[inner-input]").realPress("ArrowDown");
Expand Down Expand Up @@ -2185,7 +2185,7 @@ describe("Event firing", () => {

cy.get("#input-cb").shadow().find("[inner-input]").realClick();
cy.get("#input-cb").shadow().find("[inner-input]").realPress("ArrowDown");

cy.get("@inputSpy").should('have.been.calledOnce');
cy.get("@inputSpy").should('have.been.calledWithMatch', Cypress.sinon.match(event => {
return event.target.value === "Argentina";
Expand Down Expand Up @@ -2597,7 +2597,7 @@ describe("Event firing", () => {

cy.get("@combo").should("have.prop", "_effectiveShowClearIcon", true);
cy.get("@combo").shadow().find(".ui5-input-clear-icon-wrapper").realClick();
cy.get("@inputSpy").should('have.been.calledTwice');
cy.get("@inputSpy").should('have.been.calledTwice');
});

it("should show all items if value does not match any item and arrow is pressed", () => {
Expand Down Expand Up @@ -2843,7 +2843,7 @@ describe("ComboBox Composition", () => {
cy.get("@combobox").should("have.prop", "_isComposing", true);

cy.get("@nativeInput").trigger("compositionend", { data: "사랑" });

cy.get("@nativeInput")
.invoke("val", "사랑")
.trigger("input", { inputType: "insertCompositionText" });
Expand Down Expand Up @@ -2897,7 +2897,7 @@ describe("ComboBox Composition", () => {
cy.get("@combobox").should("have.prop", "_isComposing", true);

cy.get("@nativeInput").trigger("compositionend", { data: "ありがとう" });

cy.get("@nativeInput")
.invoke("val", "ありがとう")
.trigger("input", { inputType: "insertCompositionText" });
Expand Down Expand Up @@ -2951,7 +2951,7 @@ describe("ComboBox Composition", () => {
cy.get("@combobox").should("have.prop", "_isComposing", true);

cy.get("@nativeInput").trigger("compositionend", { data: "谢谢" });

cy.get("@nativeInput")
.invoke("val", "谢谢")
.trigger("input", { inputType: "insertCompositionText" });
Expand All @@ -2973,3 +2973,57 @@ describe("ComboBox Composition", () => {
.should("have.attr", "value", "谢谢");
});
});

describe("Validation inside a form", () => {
it("has correct validity for valueMissing", () => {
cy.mount(
<form>
<ComboBox id="cmbForm" required></ComboBox>
<button type="submit" id="submitBtn">Submit</button>
</form>
);

cy.get("form").then($form => {
$form.get(0).addEventListener("submit", (e) => e.preventDefault());
$form.get(0).addEventListener("submit", cy.stub().as("submit"));
});

cy.get("#submitBtn")
.realClick();

cy.get("@submit")
.should("have.not.been.called");

cy.get("[ui5-combobox]")
.as("combo")
.ui5AssertValidityState({
formValidity: { valueMissing: true },
validity: { valueMissing: true, valid: false },
checkValidity: false,
reportValidity: false
});

cy.get("#cmbForm:invalid")
.should("exist");

cy.get("@combo")
.realType("Albania");

cy.get("@combo")
.ui5AssertValidityState({
formValidity: { valueMissing: false },
validity: { valueMissing: false, valid: true },
checkValidity: true,
reportValidity: true
});

cy.get("#cmbForm:invalid")
.should("not.exist");

cy.get("#submitBtn")
.realClick();

cy.get("@submit")
.should("have.been.calledOnce");
});
});
181 changes: 181 additions & 0 deletions packages/main/cypress/specs/Input.cy.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2913,3 +2913,184 @@ describe("Input Composition", () => {
.should("have.attr", "value", "谢谢");
});
});

describe("Validation inside a form", () => {
it("has correct validity for valueMissing", () => {
cy.mount(
<form>
<Input id="inpForm" required></Input>
<button type="submit" id="submitBtn">Submit</button>
</form>
);

cy.get("form").then($form => {
$form.get(0).addEventListener("submit", (e) => e.preventDefault());
$form.get(0).addEventListener("submit", cy.stub().as("submit"));
});

cy.get("#submitBtn")
.realClick();

cy.get("@submit")
.should("have.not.been.called");

cy.get("[ui5-input]")
.as("input")
.ui5AssertValidityState({
formValidity: { valueMissing: true },
validity: { valueMissing: true, valid: false },
checkValidity: false,
reportValidity: false
});

cy.get("#inpForm:invalid")
.should("exist");

cy.get("@input")
.realType("Albania");

cy.get("@input")
.ui5AssertValidityState({
formValidity: { valueMissing: false },
validity: { valueMissing: false, valid: true },
checkValidity: true,
reportValidity: true
});

cy.get("#inpForm:invalid")
.should("not.exist");

cy.get("#submitBtn")
.realClick();

cy.get("@submit")
.should("have.been.calledOnce");
});

it("has correct validity for typeMismatch- Email", () => {
cy.mount(
<form>
<Input id="inpForm" required type="Email"></Input>
<button type="submit" id="submitBtn">Submit</button>
</form>
);

cy.get("form").then($form => {
$form.get(0).addEventListener("submit", (e) => e.preventDefault());
$form.get(0).addEventListener("submit", cy.stub().as("submit"));
});

cy.get("[ui5-input]")
.as("input")
.realClick()
.realType("email");

cy.get("@input")
.should("have.value", "email");

cy.get("#submitBtn")
.realClick();

cy.get("@submit")
.should("have.not.been.called");

cy.get("@input")
.ui5AssertValidityState({
formValidity: { typeMismatch: true },
validity: { typeMismatch: true, valid: false },
checkValidity: false,
reportValidity: false
});

cy.get("#inpForm:invalid")
.should("exist");

cy.get("@input")
.shadow()
.find("input")
.clear();

cy.get("@input")
.realType("email@gmail.com");

cy.get("@input")
.ui5AssertValidityState({
formValidity: { patternMismatch: false },
validity: { patternMismatch: false, valid: true },
checkValidity: true,
reportValidity: true
});

cy.get("#inpForm:invalid")
.should("not.exist");

cy.get("#submitBtn")
.realClick();

cy.get("@submit")
.should("have.been.calledOnce");
});
it("has correct validity for typeMismatch- URL", () => {
cy.mount(
<form>
<Input id="inpForm" required type="URL"></Input>
<button type="submit" id="submitBtn">Submit</button>
</form>
);

cy.get("form").then($form => {
$form.get(0).addEventListener("submit", (e) => e.preventDefault());
$form.get(0).addEventListener("submit", cy.stub().as("submit"));
});

cy.get("[ui5-input]")
.as("input")
.realClick()
.realType("google");

cy.get("@input")
.should("have.value", "google");

cy.get("#submitBtn")
.realClick();

cy.get("@submit")
.should("have.not.been.called");

cy.get("@input")
.ui5AssertValidityState({
formValidity: { typeMismatch: true },
validity: { typeMismatch: true, valid: false },
checkValidity: false,
reportValidity: false
});

cy.get("#inpForm:invalid")
.should("exist");

cy.get("@input")
.shadow()
.find("input")
.clear();

cy.get("@input")
.realType("https://www.google.com");

cy.get("@input")
.ui5AssertValidityState({
formValidity: { typeMismatch: false },
validity: { typeMismatch: false, valid: true },
checkValidity: true,
reportValidity: true
});

cy.get("#inpForm:invalid")
.should("not.exist");

cy.get("#submitBtn")
.realClick();

cy.get("@submit")
.should("have.been.calledOnce");
});
});
Loading
Loading