Skip to content

refactor(ui5-illustrated-message): aligned with ACC guidelines #12743

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
plamenivanov91 merged 2 commits into from
Dec 1, 2025
Merged

refactor(ui5-illustrated-message): aligned with ACC guidelines #12743

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9c4e86d
refactor(ui5-illustrated-message): aligned with ACC guidelines
plamenivanov91 Dec 1, 2025
f5366cb
refactor(ui5-illustrated-message): aligned with ACC guidelines
plamenivanov91 Dec 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 34 additions & 0 deletions packages/fiori/cypress/specs/IllustratedMessage.cy.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,40 @@ describe("Accessibility", () => {
.should("not.have.attr", "aria-label");

});

it("should have role=img and aria-label with illustration name when decorative is false", () => {
cy.mount(
<IllustratedMessage name="UnableToUpload" decorative={false}>
</IllustratedMessage>
);

cy.get("[ui5-illustrated-message]")
.shadow()
.find(".ui5-illustrated-message-illustration")
.should("have.attr", "role", "img");

cy.get("[ui5-illustrated-message]")
.shadow()
.find(".ui5-illustrated-message-illustration")
.should("have.attr", "aria-label", "UnableToUpload");
});

it("should have role=img and aria-label with illustration name by default (when decorative is not set)", () => {
cy.mount(
<IllustratedMessage name="NoData">
</IllustratedMessage>
);

cy.get("[ui5-illustrated-message]")
.shadow()
.find(".ui5-illustrated-message-illustration")
.should("have.attr", "role", "img");

cy.get("[ui5-illustrated-message]")
.shadow()
.find(".ui5-illustrated-message-illustration")
.should("have.attr", "aria-label", "NoData");
});
});

describe("design", () => {
Expand Down
5 changes: 4 additions & 1 deletion packages/fiori/src/IllustratedMessageTemplate.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,10 @@ export default function IllustratedMessageTemplate(this: IllustratedMessage) {
return (
<div class="ui5-illustrated-message-root">
<div class="ui5-illustrated-message-inner">
<div class="ui5-illustrated-message-illustration">
<div class="ui5-illustrated-message-illustration"
role={this.decorative ? "presentation" : "img"}
aria-hidden={this.decorative ? true : undefined}
aria-label={!this.decorative ? this.name : undefined}>
{renderIllustration.call(this)}
</div>
<div class="ui5-illustrated-message-text-and-actions-container">
Expand Down
Loading