Skip to content

chore(user-menu): acc fixes #12760

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dobromiraboycheva merged 6 commits into from
Dec 10, 2025
Merged

chore(user-menu): acc fixes #12760

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
6a4a58c
chore(user-menu): acc fixes
SvilenDarvenyashki Dec 3, 2025
678a1f5
chore(user-menu): acc fixes
SvilenDarvenyashki Dec 3, 2025
2efc104
chore(user-menu): acc fixes
SvilenDarvenyashki Dec 3, 2025
ddcedbd
chore(user-menu): acc fixes
SvilenDarvenyashki Dec 3, 2025
aee798c
Merge branch 'main' into user-menu
SvilenDarvenyashki Dec 9, 2025
01a3d21
Merge branch 'main' into user-menu
dobromiraboycheva Dec 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 11 additions & 10 deletions packages/fiori/src/UserMenuTemplate.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ export default function UserMenuTemplate(this: UserMenu) {
horizontalAlign="End"
tabindex={-1}
accessibleName={this.accessibleNameText}
aria-labelledby={this.accessibleNameText}
aria-label={this.accessibleNameText}
open={this.open}
opener={this.opener}
onClose={this._handlePopoverAfterClose}
Expand Down Expand Up @@ -94,13 +94,13 @@ export default function UserMenuTemplate(this: UserMenu) {
function headerContent(this: UserMenu) {
return (<>
{this._selectedAccount &&
<div class="ui5-user-menu-selected-account" aria-labelledby={this._ariaLabelledByAccountInformationText}>
<div class="ui5-user-menu-selected-account" aria-label={this._ariaLabelledByAccountInformationText}>
<Avatar size="L" onClick={this._handleAvatarClick} initials={this._selectedAccount._initials} fallbackIcon={personPlaceholder} class="ui5-user-menu--selected-account-avatar" interactive>
{this._selectedAccount.avatarSrc &&
<img src={this._selectedAccount.avatarSrc}/>
<img src={this._selectedAccount.avatarSrc} title={this.showEditButton ? this._editAvatarTooltip : undefined }/>
}
{this.showEditButton &&
<Tag slot="badge" wrappingType="None" design="Set1" colorScheme="5" title={this._editAvatarTooltip}>
<Tag slot="badge" wrappingType="None" design="Set1" colorScheme="5" >
<Icon slot="icon" name={edit}></Icon>
</Tag>
}
Expand Down Expand Up @@ -129,7 +129,7 @@ function headerContent(this: UserMenu) {

function otherAccountsContent(this: UserMenu) {
return (<>
<Panel collapsed={true} class="ui5-user-menu-other-accounts" aria-labelledby={this._otherAccountsButtonText}>
<Panel collapsed={true} class="ui5-user-menu-other-accounts" aria-label={this._otherAccountsButtonText}>
<div slot="header" class="ui5-user-menu-account-header">
<Title slot="header" level="H4" wrapping-type="None">{this._otherAccountsButtonText} ({this._otherAccounts.length})</Title>
{this.showEditAccounts &&
Expand All @@ -147,15 +147,16 @@ function otherAccountsContent(this: UserMenu) {

function otherAccountsList(this: UserMenu) {
return (<>
<List onItemClick={this._handleAccountSwitch} aria-labelledby={this._ariaLabelledByActions} loadingDelay={0}
<List onItemClick={this._handleAccountSwitch} aria-label={this._ariaLabelledByActions} loadingDelay={0}
loading={this._otherAccounts.some(account => account.loading === true)}>
{this._otherAccounts.map((account, index) =>
<ListItemCustom
ref={this.captureRef.bind(account)}
aria-labelledby={account.titleText}
aria-possition={index + 1}
aria-setsize={this._otherAccounts.length}
aria-dectiption={this.getAccountDescriptionText(account)}
accessibilityAttributes={{
"ariaPosinset": index + 1,
"ariaSetsize": this._otherAccounts.length
}}
aria-label={account.titleText}
>
<div class="ui5-user-menu-other-accounts-content">
<Avatar slot="image" size="S" initials={account._initials} fallbackIcon={personPlaceholder}>
Expand Down
Loading