Skip to content

ci: replace deprecated APIs #12804

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ilhan007 merged 2 commits into from
Dec 15, 2025
Merged

ci: replace deprecated APIs #12804

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
446175f
ci: replace deprecated APIs
ilhan007 Dec 15, 2025
917a52a
Merge branch 'main' into ci-update-deprecated-apis
ilhan007 Dec 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/ci-test.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ jobs:
cache: 'yarn'

- name: Install
run: yarn --frozen-lockfile
run: yarn --immutable

- name: Build
run: yarn ci:testbuild
Expand Down
6 changes: 4 additions & 2 deletions .github/workflows/deploy-preview.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,12 +80,14 @@ jobs:

if (pr.state !== 'open') {
console.log(`PR #${pr.number} was closed during build, skipping deployment`);
core.setOutput('should_deploy', 'false');
const fs = require('fs');
fs.appendFileSync(process.env.GITHUB_OUTPUT, `should_deploy=false\n`);
return;
}

console.log(`PR #${pr.number} is still open, proceeding with deployment`);
core.setOutput('should_deploy', 'true');
const fs = require('fs');
fs.appendFileSync(process.env.GITHUB_OUTPUT, `should_deploy=true\n`);

- name: Config Netlify CORS
if: steps.final-pr-check.outputs.should_deploy == 'true'
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/deploy.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ jobs:
yarn ci:deploy:nightly

- name: Deploy
uses: JamesIves/github-pages-deploy-action@v4.3.3
uses: JamesIves/github-pages-deploy-action@v4.7.6
with:
branch: gh-pages # The branch the action should deploy to.
folder: packages/website/build # The folder the action should deploy.
Expand Down Expand Up @@ -79,7 +79,7 @@ jobs:
yarn ci:deploy

- name: Deploy
uses: JamesIves/github-pages-deploy-action@v4.3.3
uses: JamesIves/github-pages-deploy-action@v4.7.6
with:
branch: gh-pages # The branch the action should deploy to.
folder: packages/website/build # The folder the action should deploy.
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/issue-close.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ jobs:
stale:
runs-on: ubuntu-latest
steps:
- uses: actions/stale@v5
- uses: actions/stale@v9
with:
# The number of days old an issue can be before marking it stale.
days-before-stale: 21
Expand Down
3 changes: 2 additions & 1 deletion .github/workflows/issue-reopen.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,8 @@ jobs:
// Allowed bots
const isSystemUser = ['ui5-webcomponents-bot', 'github-actions[bot]'].includes(commenter);

core.setOutput('shouldReopen', !isSystemUser && commentAt > closedAt);
const fs = require('fs');
fs.appendFileSync(process.env.GITHUB_OUTPUT, `shouldReopen=${!isSystemUser && commentAt > closedAt}\n`);

- name: Reopen Issue
if: steps.check.outputs.shouldReopen == 'true'
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/lint.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ jobs:
cache: 'yarn'

- name: Install Dependencies
run: yarn --frozen-lockfile
run: yarn --immutable

- name: Lint
run: yarn ci:lint
2 changes: 1 addition & 1 deletion .github/workflows/release-downport.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ jobs:
cache: 'yarn'

- name: Install
run: yarn --frozen-lockfile
run: yarn --immutable

- name: Version Bump
env:
Expand Down
8 changes: 4 additions & 4 deletions .github/workflows/release.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ jobs:
cache: 'yarn'

- name: Install Dependencies
run: yarn --frozen-lockfile
run: yarn --immutable

- name: Build
run: yarn ci:releasebuild
Expand Down Expand Up @@ -132,7 +132,7 @@ jobs:
cache: 'yarn'

- name: Install Dependencies
run: yarn --frozen-lockfile
run: yarn --immutable

- name: Build
run: yarn ci:releasebuild
Expand Down Expand Up @@ -200,7 +200,7 @@ jobs:
cache: 'yarn'

- name: Install Dependencies
run: yarn --frozen-lockfile
run: yarn --immutable

- name: Build
run: yarn ci:releasebuild
Expand Down Expand Up @@ -244,7 +244,7 @@ jobs:
cache: 'yarn'

- name: Install Dependencies
run: yarn --frozen-lockfile
run: yarn --immutable

- name: Build
run: yarn ci:releasebuild
Expand Down
4 changes: 1 addition & 3 deletions packages/base/src/UI5Element.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -277,9 +277,7 @@ abstract class UI5Element extends HTMLElement {
}

/**
* Returns a unique ID for this UI5 Element
*
* @deprecated - This property is not guaranteed in future releases
* Returns a unique ID for this UI5 Element.
* @protected
*/
get _id() {
Expand Down
Loading