-
Notifications
You must be signed in to change notification settings - Fork 277
feat(ui5-color-picker): add screenreader announcement on color mode change #12841
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+73
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
🧹 Preview deployment cleaned up: https://pr-12841--ui5-webcomponents.netlify.app |
unazko
approved these changes
Jan 6, 2026
Contributor
unazko
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The invisible message announcements are present and as specified.
tsanislavgatev
requested changes
Jan 6, 2026
…webcomponents into BL_colorpicker_announce
tsanislavgatev
approved these changes
Jan 6, 2026
Collaborator
|
🎉 This PR is included in version v2.19.0-rc.0 🎉 The release is available on v2.19.0-rc.0 Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces Screen Reader announcement on pressing the "Change color mode" (focused on image below) button of the ColorPicker.
The announcement depends on currently selected mode and values of the color components. For example:
Color mode changed to RGB. Current values: Red 255, Green 255, Blue 255, Alpha 1.Color mode changed to HSL. Current values: Hue 0, Saturation 0 %, Light 100 %, Alpha 1.JIRA: BGSOFUIBALKAN-9812