Fix completion alias mutating last message #2117
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a subtle bug where assigning to state.output.completion unintentionally mutated the last message in the message history, due to both referencing the same object.
This PR contains:
What is the current behavior? (You can also link to an open issue here)
Before, line 199 (state.output.completion = answer) would modify the last message because the completion and the last message pointed to the same thing.
What is the new behavior?
Now, the code copies the message so that they're decoupled from each other
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
No
Other information:
Encountered when using Control Arena