Fast json reading for msgs and events #2228
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains:
What is the current behavior? (You can also link to an open issue here)
Reading large eval log files is slow, particularly when extracting messages and events fields from samples. The current implementation uses Pydantic validation for all fields, which adds significant overhead.
What is the new behavior?
Added
read_eval_log_as_json()function that:Bypasses Pydantic validation entirely for faster field extraction
messagesandeventsfields from large eval logsDoes this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
No breaking changes. This adds a new optional function alongside existing functionality. Users can continue using the validated
read_eval_log()when full validation is needed, or opt intoread_eval_log_as_json()when performance is critical and validation can be skipped.