Revert "BE: Add profiling to track code optimization"#2909
Merged
Conversation
This reverts commit 4da906d.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #2901
I thought the production deployment pipeline was failing to reload the API tasks in ECS because too many of them had been triggered at the same time and it was just taking a long time to get through them. This was until I realised it was failing in all WKEs (e.g. https://github.com/UKHSA-Internal/data-dashboard-infra/actions/runs/20784424311) and actually looked at some logs and found that the health check on the new tasks were failing because of an error from this PR. Specifically, the
debug_toolbarmodule isn't available because it's a dev dependency not a prod dependency and therefore isn't available in the production images:This should be easy to fix but reverting for a quick fix and then we can revisit tomorrow.