Skip to content

CDD-2983 reject validation with missing is public with override option#2981

Open
kathryn-dale wants to merge 17 commits intomainfrom
task/CDD-2983-reject-validation-with-missing-is-public-with-override-option
Open

CDD-2983 reject validation with missing is public with override option#2981
kathryn-dale wants to merge 17 commits intomainfrom
task/CDD-2983-reject-validation-with-missing-is-public-with-override-option

Conversation

@kathryn-dale
Copy link
Copy Markdown
Contributor

@kathryn-dale kathryn-dale commented Feb 9, 2026

Description

This PR covers step two of the approach documented here: https://ukhsa.atlassian.net/browse/CDD-2983
This PR includes the following:

  • Remove default of "True" from is_public field, UNLESS override is switched on
  • Default to raise missing field error if is_public field is missed from data
  • Update test data to include is_public: true (which updates 1398 files)

Fixes #CDD-2983


Type of change

Please select the options that are relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Tech debt item (this is focused solely on addressing any relevant technical debt)

Checklist:

  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests at the right levels to prove my change is effective
  • I have added screenshots or screen grabs where appropriate
  • I have added docstrings in the correct style (google)

@kathryn-dale kathryn-dale marked this pull request as ready for review February 9, 2026 11:24
@kathryn-dale kathryn-dale requested a review from a team as a code owner February 9, 2026 11:24
@kathryn-dale kathryn-dale force-pushed the task/CDD-2983-reject-validation-with-missing-is-public-with-override-option branch from 982b7fc to 06d6190 Compare March 3, 2026 09:29
@kathryn-dale kathryn-dale force-pushed the task/CDD-2983-reject-validation-with-missing-is-public-with-override-option branch from 73ec8fe to fd5397e Compare March 3, 2026 10:03
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Mar 3, 2026

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants