Skip to content

CMS: Popular Topics grid component#3043

Open
tushortz wants to merge 6 commits intomainfrom
feature/CDD-3162-popular-topics-grid-component
Open

CMS: Popular Topics grid component#3043
tushortz wants to merge 6 commits intomainfrom
feature/CDD-3162-popular-topics-grid-component

Conversation

@tushortz
Copy link
Copy Markdown
Contributor

@tushortz tushortz commented Mar 4, 2026 •
edited
Loading

Description

This PR includes the following:

  • new popular topics card implementation

Fixes #CDD-3162

Type of change

Please select the options that are relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Tech debt item (this is focused solely on addressing any relevant technical debt)

Checklist:

  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests at the right levels to prove my change is effective
  • I have added screenshots or screen grabs where appropriate
  • I have added docstrings in the correct style (google)

@tushortz tushortz requested a review from a team as a code owner March 4, 2026 16:22
@tushortz
Copy link
Copy Markdown
Contributor Author

tushortz commented Mar 4, 2026

the duplicated lines issues raised by SonarQube are django migration duplications which we have no control over so this can be ignored.

aidan
aidan approved these changes Mar 6, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@aidan aidan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good but needs migrations regenerated

@tushortz tushortz force-pushed the feature/CDD-3162-popular-topics-grid-component branch from 2a7ec25 to c4538f9 Compare March 6, 2026 11:21
phill-stanley
phill-stanley requested changes Mar 9, 2026
View reviewed changes
@tushortz tushortz force-pushed the feature/CDD-3162-popular-topics-grid-component branch from bfe8edd to 194ce6e Compare March 11, 2026 16:13
phill-stanley
phill-stanley requested changes Mar 12, 2026
View reviewed changes
@tushortz tushortz force-pushed the feature/CDD-3162-popular-topics-grid-component branch from b2f7ce7 to b56dea1 Compare March 17, 2026 15:26
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Mar 24, 2026

Quality Gate Failed Quality Gate failed

Failed conditions
87.1% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aidan aidan aidan approved these changes

@phill-stanley phill-stanley phill-stanley approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@tushortz @aidan @phill-stanley @sahmed06