Skip to content

Task/cdd 3084 error page#3064

Open
luketowell wants to merge 13 commits intomainfrom
task/CDD-3084-error-page
Open

Task/cdd 3084 error page#3064
luketowell wants to merge 13 commits intomainfrom
task/CDD-3084-error-page

Conversation

@luketowell
Copy link
Copy Markdown
Contributor

Description

This PR includes the following:

  • New authentication error page for errors that occur whilst someone is attempting to log in to the non-public side of the dashboard.

Fixes #CDD-3084


Type of change

Please select the options that are relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Tech debt item (this is focused solely on addressing any relevant technical debt)

Checklist:

  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests at the right levels to prove my change is effective
  • I have added screenshots or screen grabs where appropriate
  • I have added docstrings in the correct style (google)

@luketowell luketowell requested a review from a team as a code owner March 12, 2026 15:26
objects = ErrorPageManager()

@classmethod
def is_previewable(cls) -> bool:
Copy link
Copy Markdown
Contributor

@mattjreynolds mattjreynolds Mar 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@luketowell Looks like this could clash with the changes @jeanpierrefouche-ukhsa is making in his PR - so probably worth just having a quick conversation to make sure they're going to work as expected when both get merged in.

@luketowell luketowell force-pushed the task/CDD-3084-error-page branch from b326839 to 6a914cc Compare April 1, 2026 15:29
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Apr 1, 2026

Quality Gate Failed Quality Gate failed

Failed conditions
18.3% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants