Skip to content

Task/cdd 3175 permission sets cms#3076

Open
luketowell wants to merge 30 commits intomainfrom
task/CDD-3175-permission-sets-cms
Open

Task/cdd 3175 permission sets cms#3076
luketowell wants to merge 30 commits intomainfrom
task/CDD-3175-permission-sets-cms

Conversation

@luketowell
Copy link
Copy Markdown
Contributor

Description

This PR includes the following:

Fixes #CDD-3175


Type of change

Please select the options that are relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Tech debt item (this is focused solely on addressing any relevant technical debt)

Checklist:

  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests at the right levels to prove my change is effective
  • I have added screenshots or screen grabs where appropriate
  • I have added docstrings in the correct style (google)

@luketowell luketowell requested a review from a team as a code owner March 17, 2026 14:00
@luketowell
Copy link
Copy Markdown
Contributor Author

@luketowell luketowell force-pushed the task/CDD-3175-permission-sets-cms branch 13 times, most recently from cae52fd to 7b91090 Compare March 26, 2026 11:29
@luketowell luketowell force-pushed the task/CDD-3175-permission-sets-cms branch from 7b91090 to 707facc Compare March 26, 2026 15:22
@luketowell luketowell force-pushed the task/CDD-3175-permission-sets-cms branch from 69cce78 to 817dfb8 Compare March 26, 2026 16:04
Copy link
Copy Markdown
Contributor

@jrdh jrdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

None of the comments I've left are because something doesn't work (except maybe the one about the API tag), just things to make the code easier to read and maintain. I also have a question which I'll drop you a message about.

@luketowell luketowell force-pushed the task/CDD-3175-permission-sets-cms branch 2 times, most recently from 7c9aca4 to eaec960 Compare March 31, 2026 15:47
@luketowell luketowell force-pushed the task/CDD-3175-permission-sets-cms branch from eaec960 to 8b15e75 Compare March 31, 2026 16:31
Copy link
Copy Markdown
Contributor

@jrdh jrdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of minor comments.

@luketowell luketowell force-pushed the task/CDD-3175-permission-sets-cms branch from 46507dd to e1502f5 Compare April 2, 2026 14:53
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Apr 2, 2026

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants