Merged
Conversation
Unit tests coverage
|
9 tasks
Use `X-UHD-AUTH` header for the JWT instead of `Authorization` header - The Authorzation header is already being used for the API key which is checked by the AWS load balancer, so commands with just the JWT are rejected. - Sending both headers means the ALB can verify the API key and send the request on to Django which can then verify the JWT
mattjreynolds
force-pushed
the
task/CDD-3145-use-custom-uhd-auth-header-for-jwt
branch
from
b4fd396 to
f9ef4a4
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use
X-UHD-AUTHheader for the JWT instead ofAuthorizationheaderCan be merged ahead of the API PR