Skip to content

Feature/cdd 3093 conditional display of the official sensitive text in headers#908

Open
manubinary wants to merge 11 commits intomainfrom
feature/CDD-3093-Conditional-display-of-the-official-sensitive-text-in-headers
Open

Feature/cdd 3093 conditional display of the official sensitive text in headers#908
manubinary wants to merge 11 commits intomainfrom
feature/CDD-3093-Conditional-display-of-the-official-sensitive-text-in-headers

Conversation

@manubinary
Copy link
Copy Markdown
Contributor

@manubinary manubinary commented Apr 7, 2026

Description

  • This PR updates the UI behavior for non-public pages by appending the selected Data Classification value to each chart card heading
  • The changes have been implemented on both the Topic page and the Child Vaccination page.

Fixes #CDD-3093

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

  • Unit tests
  • Playwright e2e tests
  • Mobile responsiveness
  • Accessibility (i.e. Lighthouse audit)
  • Disabled JavaScript

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • Any styles in this change follow the 'STYLES.md' guide
  • My changes are progressively enhanced with graceful degredagation for older browsers and non-JavaScript users
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

header change added to topic pages
Conditional display of the official sensitive text in headers
@manubinary manubinary requested a review from a team as a code owner April 7, 2026 11:53
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 7, 2026

Unit tests coverage

Lines Statements Branches Functions
Coverage: 96%
94.96% (4208/4431) 85.27% (1320/1548) 95.43% (752/788)
Tests Skipped Failures Errors Time
1639 0 💤 0 ❌ 0 🔥 28.965s ⏱️

@kathryn-dale
Copy link
Copy Markdown
Contributor

Other than the lack of unit tests lgtm

Copy link
Copy Markdown

@jeanpierrefouche-ukhsa jeanpierrefouche-ukhsa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally, the code is good! :)

However, please consider my comments below - the security design could be improved, IMHO.

replace string type with Level union type for pageClassification
replace string type with Level union type for pageClassification
@sonarqubecloud
Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants