Open
Conversation
|
Unit tests coverage
|
jeanpierrefouche-ukhsa
approved these changes
Apr 9, 2026
There was a problem hiding this comment.
LGTM. Tested locally and it works!
Good Work, Josh! :)
I would recommend:
- add some documentation to bolster up env.local. We need BASE_URL defined in the docs as a hard requirement, if feasible.
- add some documentation on how to run the e2e successfully on local machine. I have some code for this which might be good for this PR - please let me know if you would like the script.
- continue work on the ticket to bolster up the tests in general - it works reliably for me only when retries are set to > 2. There are timeout issues and many tests are failing with env.local config (perhaps more funnies in there, similar to this one! :) )
- discover why the dependency on WKEs. We "should be" testing the system, not hard-coding to specific environments.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Remove the check for the switchboard list item from the menu in the aria snapshot. This shouldn't be there full stop as it's a test page for testing API related things, but it also causes problems when attempting to run the playwright tests locally due to confusing WKE designations. See the comments on the Jira ticket 3240 for details.
Fixes #CDD-3240
Type of change
How Has This Been Tested?
Checklist: