Skip to content

Commit 0d67ac2

Browse files
committed
Remove redundant function
1 parent 1a9fdcf commit 0d67ac2

File tree

1 file changed

+3
-16
lines changed

1 file changed

+3
-16
lines changed

src/pytorch_kinematics/chain.py

Lines changed: 3 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -202,10 +202,10 @@ def get_joints(self, exclude_fixed=True):
202202
@lru_cache()
203203
def get_joint_parameter_names(self, exclude_fixed=True):
204204
names = []
205-
for f in self.get_joints(exclude_fixed=exclude_fixed):
206-
if exclude_fixed and f.joint.joint_type == 'fixed':
205+
for j in self.get_joints(exclude_fixed=exclude_fixed):
206+
if exclude_fixed and j.joint_type == 'fixed':
207207
continue
208-
names.append(f.joint.name)
208+
names.append(j.name)
209209
return names
210210

211211
@staticmethod
@@ -241,15 +241,6 @@ def get_joint_parent_frame_names(self, exclude_fixed=True):
241241
names = self._get_joint_parent_frame_names(self._root, exclude_fixed)
242242
return sorted(set(names), key=names.index)
243243

244-
@staticmethod
245-
def _get_joint_parameter_names(frame: Frame, exclude_fixed=True) -> Sequence[str]:
246-
joint_names = []
247-
if not (exclude_fixed and frame.joint.joint_type == "fixed"):
248-
joint_names.append(frame.joint.name)
249-
for child in frame.children:
250-
joint_names.extend(Chain._get_joint_parameter_names(child, exclude_fixed))
251-
return joint_names
252-
253244
@staticmethod
254245
def _get_frame_names(frame: Frame, exclude_fixed=True) -> Sequence[str]:
255246
names = []
@@ -259,10 +250,6 @@ def _get_frame_names(frame: Frame, exclude_fixed=True) -> Sequence[str]:
259250
names.extend(Chain._get_frame_names(child, exclude_fixed))
260251
return names
261252

262-
def get_joint_parameter_names(self, exclude_fixed=True):
263-
names = self._get_joint_parameter_names(self._root, exclude_fixed)
264-
return sorted(set(names), key=names.index)
265-
266253
def get_frame_names(self, exclude_fixed=True):
267254
names = self._get_frame_names(self._root, exclude_fixed)
268255
return sorted(set(names), key=names.index)

0 commit comments

Comments
 (0)