Conversation
Signed-off-by: Gerhard Steenkamp <gerhard@umaproject.org>
Signed-off-by: Gerhard Steenkamp <gerhard@umaproject.org>
Signed-off-by: Gerhard Steenkamp <gerhard@umaproject.org>
Signed-off-by: Gerhard Steenkamp <gerhard@umaproject.org>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Nit/suggestion (not a blocker for this PR): The raw string Would it be worth converting // shared/constants/oracle.ts
export const oracleTypes = {
OOV1: "Optimistic Oracle V1",
OOV2: "Optimistic Oracle V2",
OOV3: "Optimistic Oracle V3",
SkinnyOO: "Skinny Optimistic Oracle",
SkinnyOOV2: "Skinny Optimistic Oracle V2",
ManagedOOV2: "Managed Optimistic Oracle V2",
} as const;Then comparisons become Bonus: Not necessarily for this PR, but could be a nice follow-up. |
The current oracleTypes is already a readonly tuple and TSC will throw if I make a spelling error. I also get nice intellisense already. But your 2nd point is definitely a bug. I think, so reduce the diff, I will keep the constant as-is, but just use the correct |
Signed-off-by: Gerhard Steenkamp <gerhard@umaproject.org>
closes FE-388