fix: correct details sidebar labels and values for propose/verify/settled pages#265
Open
pumpedlunch wants to merge 1 commit intomasterfrom
Open
fix: correct details sidebar labels and values for propose/verify/settled pages#265pumpedlunch wants to merge 1 commit intomasterfrom
pumpedlunch wants to merge 1 commit intomasterfrom
Conversation
…tled pages - Show page-aware labels in the details sidebar: "Challenge period length" on propose, "Minimum challenge period ends" for managed OO on verify, "Challenge period ends" otherwise - Show "Proposer Reward" / "Disputer Reward" labels with correct values per page instead of a generic "Reward" label - Hide "Proposal: " prefix on the settled page for single and multiple value requests - Fix challenge period showing "2 hours" instead of actual custom liveness: `customLiveness` was fetched from the contract via `fetchRequest()` but never forwarded in `ConvertToSharedRequest` in the OOV2 ethers factory - Add `customBond` to `OracleQueryUI` to hold the raw requester-set bond before finalFee is merged in, used to compute disputer reward (bond / 2) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Files changed
libs/src/oracle-sdk-v2/services/oraclev2/ethers/factory.ts— forwardcustomLivenessfrom on-chain contract read intoSharedRequestsrc/types/ui.ts— addcustomBondfield toOracleQueryUIsrc/helpers/converters.ts— populatecustomBondinrequestToOracleQueryandassertionToOracleQuerysrc/components/Panel/Actions/Details.tsx— page-aware labels,formatLivenessDuration, disputer reward displaysrc/components/Panel/Actions/Actions.tsx— hide "Proposal: " prefix on settled pageTest plan
customLiveness = 3600— verify "Challenge period length" shows "60 minutes" (not "2 hours")bond / 2), not the proposer reward🤖 Generated with Claude Code