Conversation
Signed-off-by: Noah Hendrickson <nhendrickson2001@gmail.com>
Signed-off-by: Noah Hendrickson <nhendrickson2001@gmail.com>
Signed-off-by: Noah Hendrickson <nhendrickson2001@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR implements the
TodoList::search()function.The
itemsvector is filtered using comparisons between options,leveraging the properties of comparing
Some()toNoneto notuse
if letstatements or more verbose methods.Additionally, proper testing of the function was done for a variety
of circumstances, including a performance test in order to compare
against other versions other contributors may be working on.
To see output of the timing test, one can use the command:
A small
add_full_item()function was also added to facilitate with testing.One thing I was unsure on was the cloning of the items at the end of the search function.
Removing that cloning requires the function to return
Vec<(usize, &Item)>instead of
Vec<(usize, Item)>. Is this a fair tradeoff to make? Is one or the otherconsidered better practice when writing rust code?
As always, feedback is appreciated!
- Noah Hendrickson