Conversation
db85c88 to
369d8a2
Compare
4a22a12 to
ad4db7e
Compare
8211b11 to
1595383
Compare
remexre
commented
Oct 23, 2025
d2d8a31 to
6444554
Compare
Member
Author
|
Undrafting this; after 1363024, the allocator itself works, and the rest of the changes are definitely reviewable. This might make sense to split up; if a potential reviewer would like me to do so, I can. |
Member
Author
|
Okay, I think this is fully ready for review and merging. |
Contributor
|
started review, devicetree stuff skipped over for now, I need to read up on it prior to reviewing it. |
jastintime
requested changes
Jan 6, 2026
Contributor
jastintime
left a comment
There was a problem hiding this comment.
finished review, src/kernel/devicetree.c and src/kernel/include/devicetree.h aren't reviewed since I don't know enough about devicetree to do so.
90b1f0e to
46d18f8
Compare
Signed-off-by: Amy Ringo <me@remexre.com>
Signed-off-by: Amy Ringo <me@remexre.com>
At this point, allocation works but freeing is a no-op. Signed-off-by: Amy Ringo <me@remexre.com>
Signed-off-by: Amy Ringo <me@remexre.com>
Signed-off-by: Amy Ringo <me@remexre.com>
Signed-off-by: Amy Ringo <me@remexre.com>
Signed-off-by: Amy Ringo <me@remexre.com>
Signed-off-by: Amy Ringo <me@remexre.com>
Signed-off-by: Amy Ringo <me@remexre.com>
- page_collect shouldn't assume that the page has an empty free list, but neither should it do O(n) work when it does not. - After page_free, alloc_generic should not refer to the page anymore. Signed-off-by: Amy Ringo <me@remexre.com>
Signed-off-by: Amy Ringo <me@remexre.com>
Signed-off-by: Amy Ringo <me@remexre.com>
Signed-off-by: Amy Ringo <me@remexre.com>
Signed-off-by: Amy Ringo <me@remexre.com>
Signed-off-by: Amy Ringo <me@remexre.com>
Signed-off-by: Amy Ringo <me@remexre.com>
…data structures. Signed-off-by: Amy Ringo <me@remexre.com>
Signed-off-by: Amy Ringo <me@remexre.com>
Signed-off-by: Amy Ringo <me@remexre.com>
Signed-off-by: Amy Ringo <me@remexre.com>
Signed-off-by: Amy Ringo <me@remexre.com>
Signed-off-by: Amy Ringo <me@remexre.com>
jastintime
approved these changes
Jan 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On top of #59; merge that one first, then rebase this.There are a couple remaining bugs I'm not fixing now:
TODO()ed out anyway; we've got a bunch of places where we're going to have to make fixes to support multiple harts, so this is just one more for the list.allocandfree.vma_allocandalloc. This can probably get resolved by having the kernel virtual allocator pool some memory to use in this case, but I'm going to wait until we have a reproducer before doing this.vma_alloc_alignedcan spuriously fail when low of virtual address space. Again, I'll wait for a reproducer; this is tricky to trigger in the kernel anyway. Fixing this without a performance regression could be tricky, too; we don't want virtual address space allocation to go fromO(log2 n)toO(n)when we have lots of fragmentation, that's a DoS issue.I'll file these as issues once this is passing review, if none of them seem like blockers to a merge.
Resolves #12.
Resolves #27.