Conversation
davidcam-src
reviewed
Feb 3, 2026
|
|
||
| describe Longleaf::OcflFileCheckService do | ||
| include Longleaf::FileHelpers | ||
| ConfigBuilder ||= Longleaf::ConfigBuilder |
There was a problem hiding this comment.
curious about this syntax, I haven't seen this before. is this defining a shorthand for each of the classes under longleaf?
Member
Author
There was a problem hiding this comment.
Yeah, it's creating a shorter name for the class to use throughout the test to help with readability. I'm not sure if its actually a good practice, but it's used all over this project, maybe I got tired of seeing "Longleaf::" everywhere in tests. I have the feeling just using = instead of ||= might have caused "already initialized constant" warnings in some cases, but it doesn't seem to be the case here. Maybe it should be cleaned up at some point
davidcam-src
approved these changes
Feb 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://unclibrary.atlassian.net/browse/BXC-5529
Add service for quick file check of ocfl objects, centralize stats calculation