Skip to content

Use Debugger to give a hint about a Config Field that doesn't match a given acquisition. #331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
scott-huberty wants to merge 2 commits into
base: master
Choose a base branch
from
+11 −5
Open

Use Debugger to give a hint about a Config Field that doesn't match a given acquisition. #331

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3871815
FIX: hint
scott-huberty Mar 11, 2025
8494dc5
FIX: missing f-string
scott-huberty Mar 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 11 additions & 5 deletions dcm2bids/sidecar.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -358,7 +358,7 @@ def compare_float(name, pattern):
if len(sub_pattern) != 1:
raise ValueError(f"List for key {comparison} "
"should have only one value. "
"Error val: {sub_pattern}")
f"Error val: {sub_pattern}")

sub_pattern = float(sub_pattern[0])
else:
Expand All @@ -384,9 +384,11 @@ def compare_float(name, pattern):
if isinstance(pattern, dict):
if len(pattern.keys()) == 1:
if "any" in pattern.keys():
result.append(compare_complex(name, pattern))
is_match = compare_complex(name, pattern)
result.append(is_match)
elif list(pattern.keys())[0] in compare_float_keys:
result.append(compare_float(name, pattern))
is_match = compare_float(name, pattern)
result.append(is_match)
else:
self.logger.warning(f"This key {list(pattern.keys())[0]} "
"is not allowed.")
Expand All @@ -395,9 +397,13 @@ def compare_float(name, pattern):
"using only one key.")

elif isinstance(name, list):
result.append(compare_list(name, pattern))
is_match = compare_list(name, pattern)
result.append(is_match)
else:
result.append(compare(name, pattern))
is_match = compare(name, pattern)
result.append(is_match)
if not is_match:
self.logger.debug(f"Criteria not met for {tag}: {name} != {pattern}")

return all(result)

Expand Down